Skip to content

[dotnet] Don't break devtools processing events thread in case of unexpected exception #12820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2023
Merged

[dotnet] Don't break devtools processing events thread in case of unexpected exception #12820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion dotnet/src/webdriver/DevTools/DevToolsSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,16 @@ private void MonitorMessageQueue()
// in the IEnumerable, meaning the foreach loop will terminate gracefully.
foreach (string message in this.messageQueue.GetConsumingEnumerable())
{
this.ProcessMessage(message);
// Don't breake entire thread in case of unsuccessful message,
// and give a chance for the next message in queue to be processed
try
{
this.ProcessMessage(message);
}
catch(Exception ex)
{
LogError("Unexpected error occured while processing message: {0}", ex);
}
}
}

Expand Down