rb - add SessionNotCreatedError #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this was just never added. Looks like Jari added a few that weren't implemented 4 years ago, so I'm not sure why he didn't add this one as well. The documentation for response status indicates that it should be: 'SessionNotCreatedException.' Since Error is obviously more correct for Ruby, though, I agree with this implementation. |
titusfortner
added a commit
that referenced
this pull request
Dec 3, 2015
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
topherbullock
pushed a commit
to topherbullock/selenium
that referenced
this pull request
Oct 4, 2017
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually don't know why it was
nilbefore. There were no comments about it.But now instead of
Uncaught exception: status code 500we can get clear error message from server:Uncaught exception: Could not determine your device from Appium arguments or desired capabilities. Please make sure to specify the 'deviceName' and 'platformName' capabilities(this example comes from Appium)