Adding Governance docs #108
Conversation
|
Note: The SFC is reviewing this too! we should hear back from them soon. |
GOVERNANCE.md
Outdated
| a team player. | ||
| * Committers are expected to be respectful of every community member and to work | ||
| collaboratively in the spirit of inclusion. | ||
| * Have submitted a minimum of 10 qualifying pull requests. Where significant |
There was a problem hiding this comment.
This seems a bit arbitrary. Was this number decided elsewhere?
What about
| * Have submitted a minimum of 10 qualifying pull requests. Where significant | |
| * Have submitted substantive pull requests. Where significant |
There was a problem hiding this comment.
The number is a suggestion that I made based on other Governance models that already exist. I strongly think that we need to have a number that can be measured, otherwise things fall into a subjective area.
Do you think this number makes sense? Should we add substantive next to the numer of the number we use?
There was a problem hiding this comment.
otherwise things fall into a subjective area.
I think that's one of the best parts of an open source community. Your contributions for instance, @diemol - you didn't have 10 PRs (you had five to SeleniumHQ). But the PRs you did have were substantive and I recommended you to be on the team 👍
It is subjective and IMO it should remain that way. As long as the contributor is also +1'd by other people on the team.
There was a problem hiding this comment.
You are right, I only had 5 PRs and based on this proposal I should not have been added until I reached the 10 PRs. I also believe that having met the maintainers in person, and already maintaining a similar project helped me to get added.
I honestly think we should have a number defined, but we should reach a consensus. We should also define what substantive means. And if we only leave substantive, does that mean that one single substantive PR is enough qualification? This leaves lots of room for interpretation, and a number takes that away.
Nevertheless, as I said, if the rest of us who are watchers of this PR, are ok with leaving substantive instead of a fixed number, please just 👍 this comment. If you prefer to have a fixed number, then please 👎 this comment. If possible please add your arguments.
There was a problem hiding this comment.
This is wrong, working on IDE and Docker containers are part of the official project, just not in the selenium repo. Diego more than qualifies for this position, as does Dave.
I like having an explicit technical requirement, but it's going to be squishy either way since commits/PRs themselves aren't sufficient units of measurement (e.g. if they are all one line comment changes). I think it's fine as is so long as we recognize it as that.
There was a problem hiding this comment.
I agree with it not be strictly defined... How about wording like -
Have submitted substantive pull requests (for example a minimum of 10).
There was a problem hiding this comment.
Ok, how about this? Little wordy but more clear I would say.
(Already submitted the change, but putting it here for simplicity)
Have submitted sufficient substantive contributions to one or more of the
different projects (IDE, Docker-Selenium, Selenium, Site & Docs). For
technical contributions, enough weight is present and requires little effort to
accept because it is well documented and tested. Normally 10 substantive
contributions are needed to qualify as a candidate to be a committer, but there
could be cases where the contributions are substantial enough that a fewer
amount is also acceptable.
Co-Authored-By: Dj <daniel.jj.davison@gmail.com>
Co-Authored-By: Dj <daniel.jj.davison@gmail.com>
|
I just had a chat with Bradley from the SFC. We didn't send an email to the It's the final day of the financial year in the US right now, but hopefully "someone" from the SFC will respond to this PR either here or by email within a week. We can then respond to those comments, and merge. Because of this, I'm unilaterally suggesting we push the merge date back a week to 2020-03-10. |
GOVERNANCE.md
Outdated
| a team player. | ||
| * Committers are expected to be respectful of every community member and to work | ||
| collaboratively in the spirit of inclusion. | ||
| * Have submitted a minimum of 10 qualifying pull requests. Where significant |
There was a problem hiding this comment.
The second sentence seems to be missing a focus. I'm not sure what it's actually referring to.
Governance document proposal for the Selenium project.
The members mentioned already have the quoted role, except the TLC, which are just proposed ones.
Important: Code of Conduct is referenced in the document but it has been not created yet. This will come in a different PR.