Skip to content

Fixes #927 #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 28, 2022
Merged

Fixes #927 #1090

merged 8 commits into from
Jul 28, 2022

Conversation

jags14385
Copy link
Contributor

@jags14385 jags14385 commented Jul 28, 2022

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 8fdb506
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/62e2535fc880d60009c879e1
😎 Deploy Preview https://deploy-preview-1090--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add these changes to the other fresh_browser_per_test.*.md files?

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jags14385!

@diemol diemol merged commit e9323eb into SeleniumHQ:trunk Jul 28, 2022
selenium-ci added a commit that referenced this pull request Jul 28, 2022
* Fixes #927

* Fixes #927. made content changes as per review

* removing redundant info

* 80 characters per line fix

* Add info in the ja,pt-br,zh-cn files for the same

Co-authored-by: Jags <jags14385@users.noreply.github.com>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

Fixes #927

[deploy site] e9323eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants