-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[deploy site] fixed toml and intro message #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i comment this, the deploy failed with 61 messages of json error logs. enabled it. now it fails with this - Restore or fix website_and_docs/layouts/partials/previous-releases.html to resolve the build failure. If you need help reviewing the contents of this partial, let me know!
this is the summary of the deploy error.
i don't know now what to do to fix this, can you help @diemol , please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but what is the error you see when this is enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this error message Diego - from deploy action -"Restore or fix website_and_docs/layouts/partials/previous-releases.html to resolve the build failure. If you need help reviewing the contents of this partial, let me know!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, what is the error you see when
ignoreErrors
is commented out?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: error building site: render: failed to render pages: render of "section" failed: "/home/runner/work/seleniumhq.github.io/seleniumhq.github.io/website_and_docs/layouts/downloads/list.html:148:3": execute of template failed: template: downloads/list.html:148:3: executing "main" at <partial "previous-releases.html" .>: error calling partial: "/home/runner/work/seleniumhq.github.io/seleniumhq.github.io/website_and_docs/layouts/partials/previous-releases.html:30:27": execute of template failed: template: partials/previous-releases.html:30:27: executing "partials/previous-releases.html" at <sort $releases "created_at" "desc">: error calling sort: sequence must be provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the error you get when
ignoreErrors
does not have a#
before it.What is the error you get when
ignoreErrors
has a#
before it? (Commented)