cat: Add the -n line numbering feature #24382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
There was a problem hiding this comment.
Welcome to the project!
It doesn't really matter, but you can put the function in an anonymous namespace above the main to avoid having a declaration.
And also, it feels like output_buffer_with_line_numbers can be written in a simpler way. Feel free to try something on that side, otherwise I will give it a shot on a future review.
nico
added
⏳ pr-waiting-for-author
github-actions
bot
added
👀 pr-needs-review
LucasChollet
approved these changes
Jun 20, 2024
nico
added
⏳ pr-waiting-for-author
github-actions
bot
added
👀 pr-needs-review
nico
reviewed
Jul 4, 2024
nico
added
⏳ pr-waiting-for-author
github-actions
bot
added
👀 pr-needs-review
|
Please disregard the changes prior to this as it still does not contain the updates. Thank you for bearing with me. |
Adds the -n line numbering feature with the same formatting as gnu's cat function.
LucasChollet
approved these changes
Jul 11, 2024
LucasChollet
removed
the
👀 pr-needs-review
LucasChollet
added
the
✅ pr-community-approved
nico
reviewed
Jul 12, 2024
| @@ -11,15 +11,36 @@ | |||
| #include <LibCore/System.h> | |||
| #include <LibMain/Main.h> | |||
|
|
|||
| struct LineTracker { | |||
| size_t line_count = 1; | |||
There was a problem hiding this comment.
fyi: size_t line_count { 1 }; is what we use in most other places. I'll merge this, but if you end up touching this file again, maybe you could fix it up then.
|
Thanks! |
github-actions
bot
removed
the
✅ pr-community-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the -n line numbering feature to cat, with the same formatting as gnu's cat function.