Skip to content

JAV-389 Add spanName and callPath attribute in the span annoation. #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2017
Merged

JAV-389 Add spanName and callPath attribute in the span annoation. #175

merged 2 commits into from
Oct 10, 2017

Conversation

WillemJiang
Copy link
Member

Just let the user to override the default setting of span name and callPath.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 86.499% when pulling fa68ac3 on JAV-389 into a4eccb2 on master.

@seanyinx seanyinx requested a review from wujimin October 9, 2017 09:54
@seanyinx seanyinx requested a review from liubao68 October 9, 2017 09:54
@seanyinx seanyinx merged commit 94c0aee into master Oct 10, 2017
@seanyinx seanyinx deleted the JAV-389 branch October 10, 2017 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wujimin wujimin wujimin approved these changes

@seanyinx seanyinx seanyinx approved these changes

@liubao68 liubao68 Awaiting requested review from liubao68

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WillemJiang @coveralls @wujimin @seanyinx