JAV-469 Edge lb new instance cache manager #232
Conversation
| @Override | ||
| public ClassLoader create(String microserviceName, String version) { | ||
| public ClassLoader create(String appId, String microserviceName, String version) { | ||
| return Thread.currentThread().getContextClassLoader(); |
There was a problem hiding this comment.
If we just return the TCC, maybe we need to update the method name for it.
There was a problem hiding this comment.
this just a Default factory, another PrivateXXXFactory will do a real create
| @@ -0,0 +1,3 @@ | |||
| cse-config-order: -500 | |||
There was a problem hiding this comment.
Please add the license header here.
There was a problem hiding this comment.
discussed, no need to add license here.
|
|
||
| String microserviceVersionFactoryClass = serviceRegistryConfig.getMicroserviceVersionFactory(); | ||
| if (microserviceVersionFactoryClass == null) { | ||
| return; |
There was a problem hiding this comment.
It's better to throw exception here.
There was a problem hiding this comment.
in this version, we did not remove old cacheManager, and new cacheManager only used by edge.
so microserviceVersionFactoryClass is null, means not work with edge, will use old cacheManager, can not throw exception
There was a problem hiding this comment.
Can we add a comment to the code for it?
…erviceClassLoaderFactory
…reate interface InstanceCacheManager
…B use new InstanceCacheManager
wujimin
force-pushed
the
edge-lb-new-instance-cache-manager
branch
from
03af3ad to
2f4bbe7
Compare
4 participants
edge use new InstanceCacheManager, normal consumer use old InstanceCacheManager
if there is no problem, then old InstanceCacheManager will be deleted.