JAV-479 Optimize loadbalance #249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 8, 2017 14:12
…anged URL cause vertx found wrong failureHandler solution:changed URL only saved in VertxServerRequestToHttpServletRequest, not save to HttpServerRequest
|
Changes Unknown when pulling 37783dd on wujimin:optimize-loadbalance into ** on ServiceComb:master**. |
|
Changes Unknown when pulling c6ae907 on wujimin:optimize-loadbalance into ** on ServiceComb:master**. |
liubao68
approved these changes
Nov 10, 2017
wujimin
requested review from
WillemJiang,
liubao68 and
seanyinx
and removed request for
liubao68
WillemJiang
reviewed
Nov 10, 2017
|
|
||
| loadBalancer.chooseServer(key); | ||
| loadBalancer.getAllServers(); | ||
| loadBalancer.getServerList(true); |
There was a problem hiding this comment.
why did we call the getServerList twice which different parameter.
There was a problem hiding this comment.
no reason......
this is netflix interface, but we did not use it's input parameter.
so getServerList(true) equals getServerList(false), and equals getAllServers()
i found that did not cover getServerList, so add these two invocation.
|
big bug, do not merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
details is in https://servicecomb.atlassian.net/browse/JAV-479
in this issue, create new filter mechanism, old filters will rewrite in new Filter later.