Skip to content

Conversation

yhs0092
Copy link
Member

@yhs0092 yhs0092 commented Nov 10, 2017

See details in https://servicecomb.atlassian.net/browse/JAV-495

If URL pattern is not specified, return a default URL pattern "/*" to avoid the initialization failure of JavaChassis servlet.

Copy link
Contributor

@liubao68 liubao68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个用例应该是demo-spring-boot-transport原始要表达的意思,只是demo-spring-boot-transport在使用上有些错误。后续应该考虑demo-spring-boot-transport删除或者重新确认下其设计背景。

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 86.439% when pulling c3b1840 on yhs0092:JAV-495_set_urlPattern_default_value into 9f0e2fa on ServiceComb:master.

@yhs0092
Copy link
Member Author

yhs0092 commented Nov 11, 2017

那这个PR还能直接合并到master分支吗,是否需要修改? @liubao68

Copy link
Contributor

@wujimin wujimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不合适,不能这么改

这个配置项与web.xml中servlet-mapping都可以配置url-pattern,配置项是后出现的,需要兼容原来的用法
用法1:在web.xml中配置servlet及url-pattern
用法2:在microservice.yaml中配置url-pattern,机制动态注入servlet,并设置url-pattern

如果,将配置项中的url-pattern强制设置为有值,则用法1永久失效

@yhs0092
Copy link
Member Author

yhs0092 commented Nov 13, 2017

取消这个PR,修改后再重新提交。

@yhs0092 yhs0092 closed this Nov 13, 2017
@yhs0092 yhs0092 deleted the JAV-495_set_urlPattern_default_value branch November 14, 2017 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants