Skip to content

Conversation

qiuxd
Copy link
Contributor

@qiuxd qiuxd commented Nov 13, 2017

We could use default method in interface instead of creating an abstract class that does the same thing.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 86.468% when pulling 3a36886 on qiuxd:simplified into 0b0d024 on ServiceComb:master.

@WillemJiang
Copy link
Member

Thanks for the PR, as the AbstractHandler may be used by user, we cannot just remove this class simply without any warning message.

My suggestion is we just keep the class there and add the Deprecated annotation to let the user know about it, and then we can remove it in the next release.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 86.478% when pulling c5f023e on qiuxd:simplified into 0b0d024 on ServiceComb:master.

@WillemJiang WillemJiang self-requested a review November 15, 2017 01:18
@WillemJiang WillemJiang merged commit 2020c71 into apache:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants