JAV-495 set url pattern default value #262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2017 15:40
…ot specified, set a default URL pattern to the configuration.
…ted to a JavaChassis project.
|
@wujimin 这样修改行吗？RestServletInjector在RestServletInitializer和CseXmlWebApplicationContext有调用，现在的修改方案应该只影响到RestServletInitializer。 |
liubao68
approved these changes
Nov 15, 2017
wujimin
reviewed
Nov 16, 2017
|
|
||
| @Override | ||
| public void handle(Invocation invocation, AsyncResponse asyncResponse) throws Exception { | ||
| LOGGER.info("If you see this log, that means this demo project has been converted to ServiceComb framework."); |
There was a problem hiding this comment.
please make the case automatically
eg:
if response type is User
in handler, assign user.name = "myHandler"
then consumer determine, if user.name is empty, means did not run with serviceComb handlers
…anged URL cause vertx found wrong failureHandler solution:changed URL only saved in VertxServerRequestToHttpServletRequest, not save to HttpServerRequest
* JAV-492 Edge service not properly handle 404 requests * JAV-492 Edge service not properly handle 404 requests * Update TestEdgeInvocation.java * Update TestEdgeInvocation.java
…ot specified, set a default URL pattern to the configuration.
…ted to a JavaChassis project.
….com/yhs0092/ServiceComb-Java-Chassis into JAV-495_set_urlPattern_default_value
|
This PR is abandoned. And I will create another PR after improving the demo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in https://servicecomb.atlassian.net/browse/JAV-495
If the RestServletInitializer is invoked and URL pattern is not specified, set a default URL pattern "/*" to avoid the initialization failure of JavaChassis servlet.