JAVA-539 cse.request.timeout support dynamic refresh #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujimin
reviewed
Nov 16, 2017
| }); | ||
| }); | ||
| } | ||
| private static final Logger log = LoggerFactory.getLogger(HighwayClient.class); |
There was a problem hiding this comment.
please import codeStyle from etc/...
wujimin
reviewed
Nov 16, 2017
|
|
||
| private TcpClientConfig createTcpClientConfig() { | ||
| TcpClientConfig tcpClientConfig = new TcpClientConfig(); | ||
| DynamicLongProperty prop = DynamicPropertyFactory.getInstance().getLongProperty("cse.request.timeout", 30000); |
There was a problem hiding this comment.
"cse.request.timeout"/30000 please use const
maybe AbstractTransport add a new method to getRequestTimeoutProperty is better
wujimin
requested changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.