JAV-358 Operation filter #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubao68
reviewed
Nov 17, 2017
|
|
||
| <bean id="cse.executor.default" class="io.servicecomb.core.executor.FixedThreadExecutor"></bean> | ||
| <bean id="cse.executor.groupThreadPool" class="io.servicecomb.core.executor.FixedThreadExecutor"></bean> | ||
| <alias name="cse.executor.groupThreadPool" alias="cse.executor.default"/> |
WillemJiang
reviewed
Nov 17, 2017
| String microserviceName = pathParams.get("param0"); | ||
| String path = "/" + pathParams.get("param1"); | ||
| String pathVersion = pathParams.get("param1"); | ||
| String path = context.request().path().substring(4); |
There was a problem hiding this comment.
How can we tell the path by removing the first 4 characters?
There was a problem hiding this comment.
this is a demo
and the path rule is :/api/ms/version/......
added 3 commits
November 17, 2017 11:31
WillemJiang
reviewed
Nov 17, 2017
| invoke("/v2/dec", 2, 1, decV2Result); | ||
| invoke("/v2/dec", 3, 1, decV2Result); | ||
|
|
||
| printResults("v1/add", addV1Result); |
There was a problem hiding this comment.
We should use assert instead of printResults to check the result data.
WillemJiang
reviewed
Nov 17, 2017
| if (DynamicPropertyFactory.getInstance() | ||
| .getStringProperty(ExecutorManager.KEY_EXECUTORS_DEFAULT, null) | ||
| .get() != null) { | ||
| return; |
There was a problem hiding this comment.
we may need to do some log here.
| return; | ||
| } | ||
|
|
||
| // change default to reactive mode |
There was a problem hiding this comment.
log the edge service works in reactive mode.
liubao68
approved these changes
Nov 17, 2017
added 6 commits
November 17, 2017 11:56
…e, because use synchronize auth logic
wujimin
force-pushed
the
operation-filter
branch
from
afee43b to
4b98f73
Compare
WillemJiang
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edge service do not dispatch microservice invocation to the old instance that do not support the new operation