[JAV-504] instance not unregistered when shutdown and auto-discovery … #276
Conversation
…not work because not use the correct new sc api
| if (VERSION_V3.equals(CURRENT_VERSION)) { | ||
| REGISTRY_VERSION = "3.0.0"; // old is strange | ||
| } else { | ||
| REGISTRY_VERSION = "0.4.0"; |
There was a problem hiding this comment.
I think we just need keep tracking the API version instead of the service center version.
For Java chassis, it only knows about the service center version.
There was a problem hiding this comment.
use DefinitionConst.VERSION_RULE_ALL or use DefinitionConst.VERSION_RULE_LATEST
if SC can not support this, then it's SC's bug, must fix.
if SDK use a fixed version versionRule, then will bind to a special SC version, if SC upgraded, then SDK must update to new version.
There was a problem hiding this comment.
I am going to change this to latest according to wujimin's suggestion
| if (VERSION_V3.equals(CURRENT_VERSION)) { | ||
| REGISTRY_VERSION = "3.0.0"; // old is strange | ||
| } else { | ||
| REGISTRY_VERSION = "0.4.0"; |
There was a problem hiding this comment.
use DefinitionConst.VERSION_RULE_ALL or use DefinitionConst.VERSION_RULE_LATEST
if SC can not support this, then it's SC's bug, must fix.
if SDK use a fixed version versionRule, then will bind to a special SC version, if SC upgraded, then SDK must update to new version.
|
|
||
| public static final String REGISTRY_SERVICE_NAME = "SERVICECENTER"; | ||
|
|
||
| public static final String REGISTRY_VERSION = "3.0.0"; |
There was a problem hiding this comment.
It's not a good practise to delete the public static constant.
4 participants
1.instance not unregistered when shutdown and auto-discovery not work because not use the correct new sc api
2. and we choose any address configured first in a random fashion