JAVA-539 cse.request.timeout support dynamic refresh #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillemJiang
requested changes
Nov 20, 2017
| TcpClientConfig tcpClientConfig = new TcpClientConfig(); | ||
| tcpClientConfig.setRequestTimeoutMillis(AbstractTransport.getRequestTimeout()); | ||
| DynamicLongProperty prop = AbstractTransport.getRequestTimeoutProperty(); | ||
| prop.addCallback(new Runnable(){ |
There was a problem hiding this comment.
It's better to add a comment on this line to support setup the request timeout dynamically.
|
|
||
| private static final long DEFAULT_TIMEOUT_MILLIS = 30000; | ||
|
|
||
| private static final String DEFAULT_TIMEOUT_KEY = "cse.request.timeout"; |
There was a problem hiding this comment.
Please change the constant to REQUEST_TIMEOUT_KEY.
| ConfigUtil.installDynamicConfig(); | ||
| AbstractConfiguration configuration = | ||
| (AbstractConfiguration) DynamicPropertyFactory.getBackingConfigurationSource(); | ||
| configuration.addProperty("cse.request.timeout", 2000); |
There was a problem hiding this comment.
Please using the constant value like REQUEST_TIMEOUT_KEY here.
WillemJiang
approved these changes
Nov 20, 2017
wujimin
reviewed
Nov 21, 2017
| msRequestTimeout = msTimeout; | ||
| return msRequestTimeout; | ||
| public static DynamicLongProperty getRequestTimeoutProperty(){ | ||
| return DynamicPropertyFactory.getInstance().getLongProperty(REQUEST_TIMEOUT_KEY, DEFAULT_TIMEOUT_MILLIS); |
There was a problem hiding this comment.
no need to create the property every time.
|
@laijianbin There are two PR for the same issue, please close the PR which you don't want us to merge. |
|
no use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.