jav-479 optimizeLB add filter to distiguish instance enviroment and u… #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p stage ,this is relate to cse-554
wujimin
reviewed
Nov 21, 2017
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class StageDistinguishFilter implements ServerListFilterExt { |
There was a problem hiding this comment.
please use DiscoverFilter to impl this
and i heard that, SC will only return same stage instances, so this filter is useless?
There was a problem hiding this comment.
this feature given by SC, they will return all instances of different env's. STAGE is another scope of separation.
liubao68
requested changes
Nov 22, 2017
| instances = pulledInstances | ||
| .stream() | ||
| .filter(instance -> { | ||
| return MicroserviceInstanceStatus.UP.equals(instance.getStatus()); |
There was a problem hiding this comment.
It's better a add this logic here and filter out all other env's instances. Because this is a required feature, and filters are optional ones.
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class StageDistinguishFilter implements ServerListFilterExt { |
There was a problem hiding this comment.
this feature given by SC, they will return all instances of different env's. STAGE is another scope of separation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…p stage ,this is relate to cse-554