https://servicecomb.atlassian.net/browse/JAV-501 #307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug and add sample
2. bug gix 3. 增加UT
liubao68
reviewed
Nov 25, 2017
| @@ -0,0 +1,33 @@ | |||
| package io.servicecomb.foundation.common.utils; | |||
There was a problem hiding this comment.
code template is not correct, please check etc folder for eclipse and IDEA code template
There was a problem hiding this comment.
accept , forget to format
liubao68
reviewed
Nov 25, 2017
| public static RSAKeyPairEntry getRSAKeyPair() { | ||
| try { | ||
| KeyPairGenerator keyGenerator = KeyPairGenerator.getInstance(RSA_ALG); | ||
| keyGenerator.initialize(1024, new SecureRandom()); |
There was a problem hiding this comment.
accept ，change to 2048
liubao68
reviewed
Nov 25, 2017
| import org.apache.log4j.spi.LoggingEvent; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
| import org.junit.runners.Parameterized.Parameters; |
There was a problem hiding this comment.
unused imports, please clear all compile warnings.
liubao68
reviewed
Nov 25, 2017
| if(!token.isPresent()) | ||
| { | ||
| asyncResp.consumerFail( | ||
| new Error("rejected by consumer authentication handler")); |
There was a problem hiding this comment.
Do not throw Error for application invoke. Do you mean this will throw an Error？
There was a problem hiding this comment.
throw new Exception?
added 2 commits
November 25, 2017 18:39
2. fix ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer, I need to have authentication in service provider to protect the microservice from unauthorized access