-
Notifications
You must be signed in to change notification settings - Fork 826
fixed typos of TcpResonseCallback #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
import io.servicecomb.foundation.vertx.AsyncResultCallback; | ||
|
||
public interface TcpResonseCallback extends AsyncResultCallback<TcpData> { | ||
public interface TcpResponseCallback extends AsyncResultCallback<TcpData> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to still keep the old wrong API with deprecated annotation to warn the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thanks for pointing out.
keep the old interface i think it's not compatible. |
@wujimin You are right, the other method is public which could affect to the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine to me. We do not need to do much compatible things for typos, because this will give compile error to developers, and they can easily discover and change their code. Maybe show this in RN is enough。
No description provided.