JAV-543 Fix dns resolve #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillemJiang
reviewed
Nov 30, 2017
| @@ -0,0 +1,69 @@ | |||
| package io.vertx.ext.web.impl; | |||
| @@ -0,0 +1,81 @@ | |||
| package io.vertx.ext.web.impl; | |||
java-chassis-dependencies/pom.xml
Outdated
|
|
||
| <properties> | ||
| <jackson.version>2.8.10</jackson.version> | ||
| <vertx.version>3.5.0</vertx.version> |
Member
There was a problem hiding this comment.
This file is reformated, Can we just update the version ?
Contributor
Author
There was a problem hiding this comment.
first commit in yellow cloud, forgot if reformat it.
it's not important, right?
wujimin
force-pushed
the
fix-dns-resolve
branch
from
740b589 to
a4a8987
Compare
WillemJiang
approved these changes
Nov 30, 2017
wujimin
force-pushed
the
fix-dns-resolve
branch
from
a4a8987 to
738db83
Compare
liubao68
approved these changes
Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's netty's bug.
latest vertx had upgrade netty dependence.
we can upgrade to latest vertx 3.5.0