make name simplified & add private constructor for singleton pattern. #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wldandan
commented
Dec 3, 2017
wldandan
commented
- MicroserviceClassLoader has explicit meaning about Microservice relevant, so change the property from microserviceName to name.
- Add private constructor for singleton pattern.
WillemJiang
reviewed
Dec 3, 2017
|
|
||
| private final String appId; | ||
|
|
||
| private final String microserviceName; |
Member
There was a problem hiding this comment.
As the microserviceName is used for a while, we cannot change the name easily due to back compatible reason.
WillemJiang
reviewed
Dec 3, 2017
| public class PrivateMicroserviceClassLoaderFactory implements MicroserviceClassLoaderFactory { | ||
| public static final MicroserviceClassLoaderFactory INSTANCE = new PrivateMicroserviceClassLoaderFactory(); | ||
|
|
||
| private PrivateMicroserviceClassLoaderFactory() {} |
Member
There was a problem hiding this comment.
This change is OK. Please resubmit the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.