JAV-551 fix address binding logic, 0.0.0.0 should be replaced with a valid address #353
Conversation
|
seems that test configuration in integration-tests need to be updated with this issue. Checking file ... |
|
After modifying some configuration in integration-tests, CI has passed. Evaluation on this modification is needed to avoid losing effectiveness of these tests or other side effects. |
| address: http://127.0.0.1:30100 | ||
| rest: | ||
| address: 0.0.0.0:8080 | ||
| address: 127.0.0.1:8080 |
There was a problem hiding this comment.
为什么需要修改这里的地址？不修改会影响用例正常运行吗？
There was a problem hiding this comment.
因为现在监听IP的时候不允许监听0.0.0.0了。我们的测试里面全都是provider配的监听0.0.0.0，consumer连接用的127.0.0.1，现在这样会连不上。
其他的测试我已经改成consumer端用NetUtils获取本机IP了。但是有的测试consumer是从配置文件中获取provider的IP做连接的，不好改，所以我就改成两方都用127.0.0.1了。
| LOGGER.error("host {} is unknown.", ip); | ||
| return null; | ||
| } | ||
| if (inetAddress.isAnyLocalAddress()) { |
There was a problem hiding this comment.
Is there any security reason for this change?
We need to tell add the release-note to tell user they cannot use "0.0.0.0" any more.
There was a problem hiding this comment.
I misunderstood the requirement. I've communicated with liubao and jimin, and ensure that our current mechanism is right. This pull request will be closed later.
4 participants
see details in https://servicecomb.atlassian.net/browse/JAV-551