[JAV-554]Fix bug that when booting use java system properties for ssl configuration #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubao68
changed the title
WillemJiang
reviewed
Dec 6, 2017
| @Test | ||
| public void testSSLOptionYamlOptionWithProperyFalse() throws Exception { | ||
| System.setProperty("ssl.authPeer", "false"); | ||
| DynamicConfiguration configFromYamlFile = |
Member
There was a problem hiding this comment.
The below code is duplicated code, it's better to extract a method for setting up the configuration from system property.
Contributor
Author
There was a problem hiding this comment.
For unit test case, I think it quite important to make each test have only one logic (that is to say, code complexity is one) and code duplication is not a concern. If I extract a method, there got an "if" statement that make complexity is two. So I used to copy code for new test cases.
wujimin
reviewed
Dec 7, 2017
| @Test | ||
| public void testSSLOptionYamlOptionWithProperyTrue() throws Exception { | ||
| System.setProperty("ssl.authPeer", "true"); | ||
| DynamicConfiguration configFromYamlFile = |
Contributor
There was a problem hiding this comment.
it seems that finalConfig equals io.servicecomb.config.ConfigUtil.createLocalConfig() result?
wujimin
approved these changes
Dec 8, 2017
WillemJiang
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation