Skip to content

Commit 54567c5

Browse files
phifoggphifogg
authored
Merge pull request #27 from niamccash/master
Added check for updates in the wrong update set
2 parents 4513c6c + 9e14031 commit 54567c5

File tree

4 files changed

+47
-13
lines changed

4 files changed

+47
-13
lines changed

‎README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ Validates the description of the update sets created is not empty as it provides
5555
### Update set should not have more than 1000 updates
5656
Update sets with more than 1000 configuration updates should be broken down into multiple update sets with batching or the parent story has to be more granular as reviewing update set configs and commiting/backing out may have issues.
5757

58+
### Updates in wrong update set scope
59+
The scope for Customer Update [sys_update_xml] records should match the scope of the Update Set in which the Customer Update resides. Having a mismatch may cause Update Sets to generate preview errors meaning you cannot commit them until the errors are resolved.
60+
5861
## Category: Upgradability
5962

6063
### Incident table should not be extended

‎ca8467c41b9abc10ce0f62c3b24bcbaa/README.md‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,3 @@ If you find yourself unable to import your repository due to the presence of fil
1616
4. Run `git add -A`
1717
5. Run `git commit`
1818
6. Run `git push`
19-
20-
**Notes on dependencies**
21-
1. Dependencies will not show up in the list of changes but will be exported/imported
22-
2. It is your responsibility to resolve the dependencies before installing an application. ServiceNow source control will not manage these for you. In case you installed an application before installing its dependencies:
23-
2.1 Delete the application
24-
2.2 Activate/install all required dependencies
25-
2.3 Re-import the application from source control
26-
Currently listed dependencies:
27-
* System Update Sets (with remote update set support)
28-
* Application Design Restrictions
29-
* System (glidesoft)
30-
* Scoped App Client

‎ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
S3_MUy3wV5DdTB0n0b0MnrGJv_3DqZkWrLTyJFqhRfNt9LidkPuIPFBSAHeAm5Mz6NQvWpaC_SgSULbuuaNJWcZbMzGOe0zikIgj-4wWopY0ijk0PlDn78wwtxU0gSAl0ncaJD7ILgJ002WnLByFc6I9EiNyNpu37_bImCvWLhMwygEuoPaHNFjztFMV2pDw1TRVwIThPk60i80MJTknQj6wqq5TQQsZ1s6oquhVSLaxNkQgdJ0_Y8_S6VOxUtkhVEy-HrB0kBzwfs0ujy_1PPR_9uE_WF_UTG5ygcn-ylWme7uF7RgP9nPfQtYAjNv9ZEsFg-gHgXv1uJ-uwBVppFsZgAx_iFNa_Y8GwOLl7i_nZmA8u5fTUhvw6k7tMiUiTCz3Ue-zDvuuG0DCPa6TpsARffpsF_Ur-kx-JB-_bYnBFKvoYxxlG2nJ6v8WW2tql2yeGBPJtRO5VW1u23IiR5aXJouVi7uTLoxidC5OY2wQedQiDvIjYje_It4ZxmFhaFUu6AwHEnd-M_w6bbB3iVTrxebSV8ymssW0XauntgHRhqc-cemc0zDmv4NgkBE8CikOyfPUhjeqJfZ66CfFlQFf8vEUcfLcgrhWHpo7xNAVPYZQKvmMdJfGWpEC_MeGiVatpfhp2HCUSn4fq_92gNb9o0PC7GloFKj7hf-1Gmo
1+
pAcfdvfkVBvdcNK_HZ6Siz27BK483rysXEEssjGG27O7HfaiuDjvSeRhd0EZeVUudSzZU3oflCzpya9lTPGvDX8xgLV8BWFmL28KpbfEO9wDhxF3vjVDzgTvgZvMxTWLDKnni98ffRF_Fq1G8VDsxnVPHbv_zZSqg_uHdNPqSkKQFMJqID-neTU1JafKdsy5ugT-D7ES8hizMmLyhvApTtXYOArMEjy20glEcvh5TjcIA1u5bCRdoykZ2x79e0zcKCE76z3i7OO2ryCkiYpkIApRPOu3Z_tTcYnzQHssAekDqNtqWnsHt_QBTA9Jcpjlg48GXm47o13_1EiTQeO6XV-gl-ahpZdlBsqBIwMDiLKSveC9m2Un5s8kIz0Jq8tdhiJgiqmyP8MR2yPyYT5NkcB8OCDSn-MyIHI0ROLvKZd88WhN-jU4YGmGMdL2D-QQHnir6CXIW-uXOZ00FF6snv89TqARUGM7DJg3VL1t1uVCa8nmJQ53YKNg9C-3hC4fdZ_uB1ynKFcoAKROPTyCD58PnQHfMjDYG3BqEa-apGBAo3XsU0zI1wdS00Ia4kS1TcV4kozt_SZJZVYIPEpJ262IKgnxuOQQjDN4J6DVitEeBuefiClEGRCbIHzdyUiLvoI8Wv2gQ0a00MRkmi3ReOT1MNSYL3ODnvaNL_gdZho

‎ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_3b163adc2f9bb4505dcb59ab2799b616.xml‎

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
2+
<scan_table_check action="INSERT_OR_UPDATE">
3+
<active>true</active>
4+
<advanced>false</advanced>
5+
<attributes/>
6+
<category>manageability</category>
7+
<conditions table="sys_update_xml">applicationNSAMEASupdate_set.application^EQ<item endquery="false" field="application" goto="false" newquery="false" operator="NSAMEAS" or="false" value="update_set.application"/>
8+
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
9+
</conditions>
10+
<description>Updates in the wrong update set scope may generate an error like the following when previewed: &#13;
11+
&#13;
12+
Cannot commit Update Set 'UPDATE_SET_NAME' because: Update scope id 'x' is different than update set scope id 'y'. Resolve the problem before committing.</description>
13+
<documentation_url/>
14+
<finding_type>scan_finding</finding_type>
15+
<name>Updates in wrong update set scope</name>
16+
<priority>2</priority>
17+
<resolution_details>The scope of the Customer Update [sys_update_xml] record should match the scope of the Update Set in which it resides.</resolution_details>
18+
<run_condition/>
19+
<score_max>100</score_max>
20+
<score_min>0</score_min>
21+
<score_scale>1</score_scale>
22+
<script><![CDATA[(function (engine) {
23+
24+
// Add your code here
25+
26+
})(engine);]]></script>
27+
<short_description>Updates in wrong update set scope</short_description>
28+
<sys_class_name>scan_table_check</sys_class_name>
29+
<sys_created_by>nia.mccash</sys_created_by>
30+
<sys_created_on>2021-10-15 20:50:09</sys_created_on>
31+
<sys_id>3b163adc2f9bb4505dcb59ab2799b616</sys_id>
32+
<sys_mod_count>1</sys_mod_count>
33+
<sys_name>Updates in wrong update set scope</sys_name>
34+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
35+
<sys_policy/>
36+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
37+
<sys_update_name>scan_table_check_3b163adc2f9bb4505dcb59ab2799b616</sys_update_name>
38+
<sys_updated_by>nia.mccash</sys_updated_by>
39+
<sys_updated_on>2021-10-23 23:25:03</sys_updated_on>
40+
<table>sys_update_xml</table>
41+
<use_manifest>false</use_manifest>
42+
</scan_table_check>
43+
</record_update>

0 commit comments

Comments
 (0)