Updated Examples With Comments, Added NuGet References #19

Merged
merged 1 commit into from Sep 24, 2012

Projects

None yet

2 participants

Contributor

Added NuGet references to projects. Removed referenced assemblies from lib folder. Updated some of the examples with comments using the Xml documentation format supported by Visual Studio. Please let me know what you like, don't like. Based on your feedback, I can update the rest of the projects.

Owner
mythz commented Sep 19, 2012

Hi Michael,

That's one mega commit, thx :)

The only things I can think of is that Content is likely a more familiar folder name in .NET than assets so it would be best to go with that instead. Also we should be able to drop the [DataContract] and [DataMember] attributes now and just have cleaner attribute-less POCOs where they're not needed (i.e. where Name/Namespace isn't specified).

Apart from those minor details, it's looking good.

Contributor

Great! I'll keep going. Thanks for the feedback.

Contributor

I made some additional changes based on your recommendations.

Owner
mythz commented Sep 24, 2012

Hi Michael, Sweet thanks for this, it looks good.

Sorry for the delayed Response, I was busy finishing ServiceStack's new API Design :)

As the new API is much better than the old one, I'm going to start porting all the examples to use it. It will probably take me a while to do slowly over the next few weeks - you're welcome to help out if you have some time.

@mythz mythz merged commit 9503a88 into ServiceStack:master Sep 24, 2012
Contributor

How exciting! So far I like what I see. Just let me know where you want me
to start and I'll make the changes that I can.

On Mon, Sep 24, 2012 at 3:14 AM, Demis Bellot notifications@github.comwrote:

Hi Michael, Sweet thanks for this, it looks good.

Sorry for the delayed Response, I was busy finishing ServiceStack's new
API Design https://github.com/ServiceStack/ServiceStack/wiki/New-API :)

As the new API is much better than the old one, I'm going to start porting
all the examples to use it. It will probably take me a while to do slowly
over the next few weeks - you're welcome to help out if you have some time.


Reply to this email directly or view it on GitHubhttps://github.com/ServiceStack/ServiceStack.Examples/pull/19#issuecomment-8810146.

Owner
mythz commented Sep 24, 2012

Hi Michael,

I've got a few other things going on atm, so I wont be able to get started on it for a while, but if you're keen it'd be awesome you have a crack at it!

At the bottom of this page:
https://github.com/ServiceStack/ServiceStack/wiki/New-API

I've gone through the process of converting a single service, it wont cover all use-cases but it's a good start to highlight the differences between the old and new api styles.

Contributor

I was reviewing it and looks pretty straightforward. I'll do whatever I can
and then you can just review it once your schedule opens back up.

On Mon, Sep 24, 2012 at 1:35 PM, Demis Bellot notifications@github.comwrote:

Hi Michael,

I've got a few other things going on atm, so I wont be able to get started
on it for a while, but if you're keen it'd be awesome you have a crack at
it!

At the bottom of this page:
https://github.com/ServiceStack/ServiceStack/wiki/New-API

I've gone through the process of converting a single service, it wont
cover all use-cases but it's a good start to highlight the differences
between the old and new api styles.


Reply to this email directly or view it on GitHubhttps://github.com/ServiceStack/ServiceStack.Examples/pull/19#issuecomment-8829419.

Owner
mythz commented Sep 24, 2012

Sweet sounds like a plan.

Feel free to ping me with any Q's you run into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment