This repository was archived by the owner on Dec 24, 2022. It is now read-only.
Don't bother title-casing property names for lenient lookup #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling shows a significant amount of decoding time (>25%!) in this hotspot when dealing with large, repetitive JSON documents using underscore_style property names and requiring the lenient lookup. The good news is there is no need to title case at all, once we remove hyphens and underscores. The type accessor map uses a case-insensitive lookup function, so any case will do. Note that no tests need modification post-patch (although several would fail without the hyphen/underscore removal).
toofishes
changed the title
|
ok great, thx for the perf analysis on this Dan. Can you approve the Contributor License Agreement so we can merge this, cheers. |
|
I just approved the CLA. |
mythz
added a commit
that referenced
this pull request
Jul 24, 2014
Don't bother title-casing property names for lenient lookup
|
cheers 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling shows a significant amount of decoding time (>25%!) in this
hotspot when dealing with large, repetitive JSON documents using
underscore_style property names and requiring the leinent lookup.
The good news is there is no need to title case at all, once we remove
hyphens and underscores. The type accessor map uses a case-insensitive
lookup function, so any case will do. Note that no tests need modification
post-patch (although several would fail without the hyphen/underscore
removal).