Skip to content

Add Curve Support in Leveraged EI #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ckoopmann merged 42 commits into from
Mar 24, 2022
Merged

Add Curve Support in Leveraged EI #100

ckoopmann merged 42 commits into from
Mar 24, 2022

Conversation

@ckoopmann
Copy link
Collaborator

@ckoopmann ckoopmann commented Mar 16, 2022

No description provided.

@ckoopmann ckoopmann marked this pull request as draft March 16, 2022 03:40
Christian Koopmann and others added 20 commits March 17, 2022 12:16
Add implementation of exact output swap on curve
3f784fe
Collect integration tests meant to be run on polygon fork in one dire…
cde5ad3 
…ctory
Add ethereum integration test skeleton
77fb2b9
Increase pinned block number for eth mainnet fork
80aed60
Test curve swap methods
2f686c4
Extend tests of curve integration
8c019ad
Test failing when trying to do two exact output swaps
f262cc2
Reset to snapshot to avoid failure on second exactOutput swap
518ea2c
Move exchange selection to swapData
b7bbc32
More tweeking of integration tests
ef68af8
Fix unittests
e6d45cb
Fix linter errors in integrationtest
e052059
Add ethereum integration test to circleci workflow
b1dc4e3
Add staging addresses to integration test
e142783
Fix wrong path in polygon integration test
4700e31
Remove snapshot resets from polygon integration tests
1feec8c
Approve icEth token in integrationtest
8b814a1
Add attempt issuance with collateral token to ethereum integration test
9a4d326
Log statements to illustrate aave issue
4553a6c
First working test case for icEth issuance from stEth
451e9f6
ckoopmann
ckoopmann commented Mar 24, 2022
View reviewed changes
ckoopmann
ckoopmann commented Mar 24, 2022
View reviewed changes
ckoopmann
ckoopmann commented Mar 24, 2022
View reviewed changes
@ckoopmann ckoopmann marked this pull request as ready for review March 24, 2022 02:11
ncitron
ncitron approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you just remove the TODO comments leftover from the thread before you merge

@ckoopmann ckoopmann merged commit d8e029c into IndexCoop:master Mar 24, 2022
@FlattestWhite
Copy link
Contributor

FlattestWhite commented Mar 24, 2022

🎉 This PR is included in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ace3 pushed a commit to ace3/index-coop-smart-contracts that referenced this pull request Feb 2, 2024
@bweick
Patch for real -> virtual -> real unit conversion. (IndexCoop#100)
c05d9ef 
Patch for real -> virtual -> real unit conversion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ncitron ncitron ncitron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ckoopmann @FlattestWhite @ncitron