feat: Exchange Issuance for Leveraged Tokens #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith flashloan interface
ckoopmann
commented
Feb 23, 2022
| _decodedParams.limitAmount, | ||
| _decodedParams.leveragedTokenData | ||
| ); | ||
| require(amountInputTokenSpent <= _decodedParams.limitAmount, "ExchangeIssuance: INSUFFICIENT INPUT AMOUNT"); |
Collaborator
Author
There was a problem hiding this comment.
This is where I moved to max/minAmount checks. @ncitron : Let me know if this is "top level" enough.
…port Leveraged EI UniV3 support
ncitron
approved these changes
Mar 4, 2022
Contributor
ncitron
left a comment
ncitron
left a comment
There was a problem hiding this comment.
Mostly just nitpicks here. Can you go through and do a detailed check of the formatting. Mostly I've notices a bunch of spots where the indentation is off or the javadoc params do not reflect the current function args. I flagged a few examples but there's a bunch of spots that I didn't point out. Once these are addressed, feel free to merge.
Good job on this!
…ed-exchange-issuance
ckoopmann
changed the title
Contributor
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ace3
pushed a commit
to ace3/index-coop-smart-contracts
that referenced
this pull request
Feb 2, 2024
* low hanging audit changes * fix tests * audit changes * fix tests * improve tests * clean up contracts * use removeStorage * review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exchange Issuance for Leveraged Tokens: