-
Notifications
You must be signed in to change notification settings - Fork 106
Add optimism client to CI and test set core deployment #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6488e03
to
7713be0
Compare
1af8a9e
to
37b37e2
Compare
if (value > 0){ | ||
bool success = WETHTransfer(target, value); | ||
_verifyCallResult(success, "", "Address: WETH transfer failed"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should go after call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, need to investigate how value
gets compiled down...current order might be right.
Also double check current Optimism's client's management of this to see if necessary.
Closing for the moment ... will revisit when support for Optimism is scheduled. |
DO NOT MERGE: TARGETS #81
TODO
tsc
error on build 4d6cff5