Skip to content

Conversation

cgewecke
Copy link
Contributor

@cgewecke cgewecke commented Apr 30, 2021

DO NOT MERGE: TARGETS #81

  • Adds Optimism client in CI
  • Adds tests to validate core system deploys successfully to L2
  • Enables SetToken unit tests on L2

TODO

  • Add CI job to run tests over core subset with Hardhat EVM (to validate SetToken restructuring)
    • Figure out test selection strategy for both clients (since some tests will only succeed on OVM)
  • Get critical tests passing on Optimism client in CI
    • Add revert helper
    • SetToken
    • BasicIssuance
  • Add L1 -> L2 Eth deposits f5d3c88
  • Publish built docker images to SetProtocol github packages account 37b37e2
  • Add installation instructions / script for local development 6dc1c33
  • Normalize library function signatures for external calls (e.g no IERC20 data type) and clean up contract changes
  • Fix eth-optimism core-utils tsc error on build 4d6cff5

@cgewecke cgewecke force-pushed the chris/optimism-client-setup branch from 6488e03 to 7713be0 Compare April 30, 2021 22:02
@cgewecke cgewecke force-pushed the chris/optimism-client-setup branch from 1af8a9e to 37b37e2 Compare May 12, 2021 22:16
if (value > 0){
bool success = WETHTransfer(target, value);
_verifyCallResult(success, "", "Address: WETH transfer failed");
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should go after call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, need to investigate how value gets compiled down...current order might be right.

Also double check current Optimism's client's management of this to see if necessary.

@cgewecke cgewecke changed the base branch from chris/optimism-settoken-restructure to chris/solc-0.6.12 May 13, 2021 18:22
@cgewecke
Copy link
Contributor Author

cgewecke commented Oct 6, 2021

Closing for the moment ... will revisit when support for Optimism is scheduled.

@cgewecke cgewecke closed this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant