fix date/time rounding issue #2717
Conversation
See: #2560 - Improved rounding to account for minutes, hours, etc. - Added tests for rounding dates/times
|
The tests predictably failed on old node versions since they did not support ES6 destructuring. Did you test against the examples provided by @snoopyjc in #2560 (comment) ? |
|
Thanks for the quick reply, @SheetJSDev. I have added @snoopyjc's test cases, and the syntax should be fully compatible with ES3 now. |
SheetJSDev
force-pushed
the
master
branch
2 times, most recently
from
f699120
to
ef6d308
Compare
|
@SheetJSDev I would like to get this change merged if there aren't any other issues and you think it's appropriate. Is there anything else I need to do? |
|
Nothing else on your end. There are some logistical issues we are figuring out regarding date handling. Ideally, 0.19.0 resolves the outstanding date processing problems which requires both the SSF formatting library and the main file processing library to agree on date code interpretation. |
|
Thanks for all your work! |
|
Are there any updates on this? At a quick glance, I'm not able to reproduce this here: https://oss.sheetjs.com/ssf/ but want to make sure this has been fixed and what version it's been fixed in |
See: #2560