feat!: Dropped support for Node 18 and updated dependencies.

ShogunPanda · ShogunPanda · commit fa33aec537af · 2024-10-20T09:38:11.000+02:00
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,10 +7,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: Use Node.js LTS
+      - name: Use supported Node.js Version
         uses: actions/setup-node@v3
         with:
-          node-version: lts/*
+          node-version: 20.18.0*
       - name: Restore cached dependencies
         uses: actions/cache@v3
         with:
diff --git a/.swcrc b/.swcrc
@@ -1,6 +1,6 @@
 {
   "jsc": {
-    "target": "es2022",
+    "target": "esnext",
     "parser": {
       "syntax": "typescript",
       "tsx": false,
diff --git a/eslint.config.js b/eslint.config.js
@@ -0,0 +1,12 @@
+import { cowtech } from '@cowtech/eslint-config'
+
+export default [
+  ...cowtech,
+  {
+    languageOptions: {
+      parserOptions: {
+        project: './tsconfig.test.json'
+      }
+    }
+  }
+]
diff --git a/package.json b/package.json
@@ -45,32 +45,32 @@
     "build": "swc --strip-leading-paths --delete-dir-on-start -d dist src",
     "postbuild": "concurrently npm:lint npm:typecheck",
     "format": "prettier -w src test",
-    "lint": "eslint --cache --ext .js,.jsx,.ts,.tsx src test",
+    "lint": "eslint --cache",
     "typecheck": "tsc -p . --emitDeclarationOnly",
-    "test": "c8 -c test/config/c8-local.json node --import tsx --test test/*.test.ts",
-    "test:ci": "c8 -c test/config/c8-ci.json node --import tsx --test-reporter=tap --test test/*.test.ts",
+    "test": "c8 -c test/config/c8-local.json node --env-file=test.env --test test/*.test.ts",
+    "test:ci": "c8 -c test/config/c8-ci.json node --env-file=test.env --test-reporter=tap --test test/*.test.ts",
     "ci": "npm run build && npm run test:ci",
     "prepublishOnly": "npm run ci",
     "postpublish": "git push origin && git push origin -f --tags"
   },
   "dependencies": {
     "image-size": "^1.1.1",
-    "undici": "^6.13.0"
+    "undici": "^6.20.1"
   },
   "devDependencies": {
-    "@cowtech/eslint-config": "^9.0.3",
-    "@swc/cli": "^0.3.12",
-    "@swc/core": "^1.4.13",
-    "@types/node": "^20.12.7",
-    "c8": "^9.1.0",
-    "chokidar": "^3.6.0",
-    "concurrently": "^8.2.2",
-    "eslint": "^8.57.0",
-    "prettier": "^3.2.5",
-    "tsx": "^4.7.2",
-    "typescript": "^5.4.5"
+    "@cowtech/eslint-config": "10.0.0",
+    "@swc-node/register": "^1.10.9",
+    "@swc/cli": "0.4.1-nightly.20240914",
+    "@swc/core": "^1.7.36",
+    "@types/node": "^22.7.7",
+    "c8": "^10.1.2",
+    "chokidar": "^4.0.1",
+    "concurrently": "^9.0.1",
+    "eslint": "^9.13.0",
+    "prettier": "^3.3.3",
+    "typescript": "^5.6.3"
   },
   "engines": {
-    "node": ">= 18.18.0"
+    "node": ">= 20.18.0"
   }
 }
diff --git a/src/internals.ts b/src/internals.ts
@@ -148,7 +148,7 @@ export function handleError(error: FastImageError, url: string): Error {
     case 'ECONNREFUSED':
       message = 'Connection refused from the remote host.'
       break
-    /* c8 ignore next */
+    /* c8 ignore next 2 */
     case 'ETIMEDOUT':
     case 'UND_ERR_HEADERS_TIMEOUT':
       message = 'Connection to the remote host timed out.'
diff --git a/src/stream.ts b/src/stream.ts
@@ -39,12 +39,12 @@ export class FastImageStream extends Writable {
     )
   }
 
+  /* c8 ignore start  */
   _write(chunk: Buffer, _e: BufferEncoding, cb: (error?: Error | null) => void): void {
     this.analyze(chunk)
     cb()
   }
 
-  /* c8 ignore start  */
   _writev(chunks: { chunk: Buffer }[], cb: (error?: Error | null) => void): void {
     for (const { chunk } of chunks) {
       this.analyze(chunk)
diff --git a/test.env b/test.env
@@ -0,0 +1 @@
+NODE_OPTIONS=--import @swc-node/register/esm-register
diff --git a/test/buffersAndStreams.test.ts b/test/buffersAndStreams.test.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-floating-promises */
-
 import { deepStrictEqual, rejects } from 'node:assert'
 import { createReadStream, readFileSync } from 'node:fs'
 import { test } from 'node:test'
diff --git a/test/files.test.ts b/test/files.test.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-floating-promises */
-
 import { deepStrictEqual, ifError } from 'node:assert'
 import { chmodSync, existsSync, unlinkSync, writeFileSync } from 'node:fs'
 import { dirname } from 'node:path'
diff --git a/test/index.test.ts b/test/index.test.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-floating-promises */
-
 import { deepStrictEqual, ok, rejects } from 'node:assert'
 import { test } from 'node:test'
 import { info } from '../src/index.js'
diff --git a/test/streams.test.ts b/test/streams.test.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-floating-promises */
-
 import { deepStrictEqual } from 'node:assert'
 import { createReadStream } from 'node:fs'
 import { test } from 'node:test'
diff --git a/test/urls.test.ts b/test/urls.test.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-floating-promises */
-
 import { deepStrictEqual, ok, rejects } from 'node:assert'
 import { readFileSync } from 'node:fs'
 import { createServer as createHttpServer } from 'node:http'
@@ -52,10 +50,18 @@ test('fastimage.info', async () => {
     })
 
     await test('should handle connection timeouts', async () => {
+      const server = createServer(c => {})
+
+      server.listen({ port: 0 })
+
+      const url = `http://127.0.0.1:${(server.address() as AddressInfo).port}`
+
       await rejects(
-        info('https://fakeimg.pl/1000x1000/', { timeout: 10 }),
-        new FastImageError('Connection to the remote host timed out.', 'NETWORK_ERROR', 'https://fakeimg.pl/1000x1000/')
+        info(url, { timeout: 10 }),
+        new FastImageError('Connection to the remote host timed out.', 'NETWORK_ERROR', url)
       )
+
+      server.close()
     })
 
     await test('should handle connection failures', async () => {
diff --git a/tsconfig.json b/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "ES2022",
+    "target": "ESNext",
     "module": "NodeNext",
     "moduleResolution": "NodeNext",
     "jsx": "preserve",

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"jsc": {`
`3`		`- "target": "es2022",`
	`3`	`+ "target": "esnext",`
`4`	`4`	`"parser": {`
`5`	`5`	`"syntax": "typescript",`
`6`	`6`	`"tsx": false,`
Original file line number	Diff line number	Diff line change
`@@ -39,12 +39,12 @@ export class FastImageStream extends Writable {`
`39`	`39`	`)`
`40`	`40`	`}`
`41`	`41`
	`42`	`+ /* c8 ignore start */`
`42`	`43`	`_write(chunk: Buffer, _e: BufferEncoding, cb: (error?: Error \| null) => void): void {`
`43`	`44`	`this.analyze(chunk)`
`44`	`45`	`cb()`
`45`	`46`	`}`
`46`	`47`
`47`		`- /* c8 ignore start */`
`48`	`48`	`_writev(chunks: { chunk: Buffer }[], cb: (error?: Error \| null) => void): void {`
`49`	`49`	`for (const { chunk } of chunks) {`
`50`	`50`	`this.analyze(chunk)`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+NODE_OPTIONS=--import @swc-node/register/esm-register`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-/* eslint-disable @typescript-eslint/no-floating-promises */`
`2`		`-`
`3`	`1`	`import { deepStrictEqual, rejects } from 'node:assert'`
`4`	`2`	`import { createReadStream, readFileSync } from 'node:fs'`
`5`	`3`	`import { test } from 'node:test'`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-/* eslint-disable @typescript-eslint/no-floating-promises */`
`2`		`-`
`3`	`1`	`import { deepStrictEqual, ifError } from 'node:assert'`
`4`	`2`	`import { chmodSync, existsSync, unlinkSync, writeFileSync } from 'node:fs'`
`5`	`3`	`import { dirname } from 'node:path'`