[ResourceList] Make se23 styles the default #10055
Conversation
jesstelford
force-pushed
the
resource-list-se23-cleanup
branch
from
5bb9000 to
b6442b7
Compare
| border-top: var(--p-border-width-1) solid var(--p-color-border-subdued); | ||
|
|
||
| #{$se23} & { | ||
| border-top: none; |
There was a problem hiding this comment.
This border-top: none; was to reset the border-top above before item-separator sets a new border-top... ie; We want item-separator's border-top to win in SE23, so removing the pre-uplift one means we can remove the reset also.
| // se23: This is the initial value of flex, is there something else that mutates this in other components? | ||
| @media #{$p-breakpoints-sm-up} { | ||
| flex: 0 1 auto; | ||
| align-self: flex-start; |
There was a problem hiding this comment.
The specificity of this @media #{$p-breakpoints-sm-up} matches the #{$se23} & below, but #{$se23} & wins because it comes last. Therefore, align-self: flex-start never gets applied and so can now be deleted 👍
|
|
||
| // se23: This is the initial value of flex, is there something else that mutates this in other components? | ||
| @media #{$p-breakpoints-sm-up} { | ||
| flex: 0 1 auto; |
There was a problem hiding this comment.
As per the above comment; this is the default. There's no other flex rules set on this element, so it's safe to remove this. (Looks like it might have been a refactor hold-over from when Bulk Editor was introduced).
sam-b-rose
force-pushed
the
next
branch
4 times, most recently
from
5d459f8 to
700a72f
Compare
jesstelford
force-pushed
the
resource-list-se23-cleanup
branch
from
b6442b7 to
4e00067
Compare
Completes #9962
Storybook.
NOTE: There's some existing layout jank in
<ResourceList>that I've fixed separately in #10056