This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[ResourceList] Remove layout jank when bulk actions enabled and item selected #10056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2023
gwyneplaine
approved these changes
Aug 15, 2023
jesstelford
force-pushed
the
resource-list-jank
branch
2 times, most recently
from
3647f71 to
449caa4
Compare
|
do you think this should be merged into |
|
Yeah, on second thought it's probably better to get this fix out and merge |
jesstelford
force-pushed
the
resource-list-se23-cleanup
branch
from
b6442b7 to
4e00067
Compare
jesstelford
force-pushed
the
resource-list-jank
branch
from
449caa4 to
ef4b4d5
Compare
jesstelford
force-pushed
the
resource-list-jank
branch
from
ef4b4d5 to
e9c9271
Compare
jesstelford
force-pushed
the
resource-list-jank
branch
from
e9c9271 to
0d37731
Compare
Merged
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 24, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.20.0 ### Minor Changes - [#10101](#10101) [`e6a2d352a`](e6a2d35) Thanks [@samrose3](https://github.com/samrose3)! - Removed the `@shopify/polaris-cli` and `@shopify/polaris-codemods` package in favor of using only the `@shopify/polaris-migrator`. Removing these packages will provide the following benefits: - Improve CI time by removing extra packages from our build, test, and lint workflows - Reduce confusion on where to add new migrations or update previous migrations - Clean up ESLint configs, reduce changelog entries, and remove package dependencies - [#10071](#10071) [`23c1391aa`](23c1391) Thanks [@kyledurand](https://github.com/kyledurand)! - Added support for compound components and adding new prop values in the react-rename-component-prop migration ## @shopify/polaris@11.13.0 ### Minor Changes - [#10086](#10086) [`5a5b3795a`](5a5b379) Thanks [@joelzwarrington](https://github.com/joelzwarrington)! - [Modal] Activator no longer wrapped in Box - [#10183](#10183) [`7891c7ed9`](7891c7e) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecate connectedDisclosure prop on button - [#10181](#10181) [`219be15aa`](219be15) Thanks [@ssetem](https://github.com/ssetem)! - Added support for [Dynamic Type](https://developer.apple.com/documentation/uikit/uifont/scaling_fonts_automatically) in iOS ### Patch Changes - [#10056](#10056) [`5ecaafc2b`](5ecaafc) Thanks [@jesstelford](https://github.com/jesstelford)! - [ResourceList] Remove layout jank when bulk actions enabled and item selected - [`bc1f4aab1`](bc1f4aa) Thanks [@samrose3](https://github.com/samrose3)! - Reduced surrounding margin of Tooltip to allow for interaction with nearby UI elements. ## polaris.shopify.com@0.57.1 ### Patch Changes - [#10186](#10186) [`b340df129`](b340df1) Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - Fixed landing page for sandbox - Updated dependencies \[[`5a5b3795a`](5a5b379), [`7891c7ed9`](7891c7e), [`5ecaafc2b`](5ecaafc), [`bc1f4aab1`](bc1f4aa), [`219be15aa`](219be15)]: - @shopify/polaris@11.13.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.20.0 ### Minor Changes - [Shopify#10101](Shopify#10101) [`e6a2d352a`](Shopify@2d142bb) Thanks [@samrose3](https://github.com/samrose3)! - Removed the `@shopify/polaris-cli` and `@shopify/polaris-codemods` package in favor of using only the `@shopify/polaris-migrator`. Removing these packages will provide the following benefits: - Improve CI time by removing extra packages from our build, test, and lint workflows - Reduce confusion on where to add new migrations or update previous migrations - Clean up ESLint configs, reduce changelog entries, and remove package dependencies - [Shopify#10071](Shopify#10071) [`23c1391aa`](Shopify@4e11e7a) Thanks [@kyledurand](https://github.com/kyledurand)! - Added support for compound components and adding new prop values in the react-rename-component-prop migration ## @shopify/polaris@11.13.0 ### Minor Changes - [Shopify#10086](Shopify#10086) [`5a5b3795a`](Shopify@f8cb874) Thanks [@joelzwarrington](https://github.com/joelzwarrington)! - [Modal] Activator no longer wrapped in Box - [Shopify#10183](Shopify#10183) [`7891c7ed9`](Shopify@5febc40) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecate connectedDisclosure prop on button - [Shopify#10181](Shopify#10181) [`219be15aa`](Shopify@5892203) Thanks [@ssetem](https://github.com/ssetem)! - Added support for [Dynamic Type](https://developer.apple.com/documentation/uikit/uifont/scaling_fonts_automatically) in iOS ### Patch Changes - [Shopify#10056](Shopify#10056) [`5ecaafc2b`](Shopify@06a127d) Thanks [@jesstelford](https://github.com/jesstelford)! - [ResourceList] Remove layout jank when bulk actions enabled and item selected - [`bc1f4aab1`](Shopify@9d26367) Thanks [@samrose3](https://github.com/samrose3)! - Reduced surrounding margin of Tooltip to allow for interaction with nearby UI elements. ## polaris.shopify.com@0.57.1 ### Patch Changes - [Shopify#10186](Shopify#10186) [`b340df129`](Shopify@95e35db) Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - Fixed landing page for sandbox - Updated dependencies \[[`5a5b3795a`](Shopify@f8cb874), [`7891c7ed9`](Shopify@5febc40), [`5ecaafc2b`](Shopify@06a127d), [`bc1f4aab1`](Shopify@9d26367), [`219be15aa`](Shopify@5892203)]: - @shopify/polaris@11.13.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10055
Storybook
Before this PR (1px vertical layout shift):
This PR:
Caused by a missing
border-topon the top item when any item is selected & bulk actions are enabled.