This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[TextField] Allow TextField to disable 1Password integration #10394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @mrcthms! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230911121511yarn add @shopify/polaris@0.0.0-snapshot-release-20230911121511yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230911121511yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230911121511 |
chloerice
approved these changes
Sep 11, 2023
chloerice
reviewed
Sep 11, 2023
Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Merged
mrcthms
pushed a commit
that referenced
this pull request
Sep 14, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@11.18.0 ### Minor Changes - [#10429](#10429) [`2e65a7e98`](2e65a7e) Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed `Filters` pinned filter pill not remaining when applied values are cleared - [#10394](#10394) [`b7f25f07f`](b7f25f0) Thanks [@mrcthms](https://github.com/mrcthms)! - Added support for disabling 1Password integration in `TextField` - [#10406](#10406) [`87f559ca1`](87f559c) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated the Toast component to support multiple re-renders being announced on screen readers ### Patch Changes - [#10428](#10428) [`d35d55e5b`](d35d55e) Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed layout shift in `IndexFilters` when switching modes - Updated dependencies \[[`26ab8ce7d`](26ab8ce), [`7514dd1a3`](7514dd1), [`16c61668a`](16c6166)]: - @shopify/polaris-tokens@7.8.0 ## @shopify/polaris-tokens@7.8.0 ### Minor Changes - [#10432](#10432) [`26ab8ce7d`](26ab8ce) Thanks [@lgriffee](https://github.com/lgriffee)! - Added public primitive `border-radius` token scale - [#10448](#10448) [`7514dd1a3`](7514dd1) Thanks [@lgriffee](https://github.com/lgriffee)! - Added public primitive `space` token scale - [#10418](#10418) [`16c61668a`](16c6166) Thanks [@lgriffee](https://github.com/lgriffee)! - Added private primitive `size` token scale ## @shopify/polaris-migrator@0.22.3 ### Patch Changes - Updated dependencies \[[`26ab8ce7d`](26ab8ce), [`7514dd1a3`](7514dd1), [`16c61668a`](16c6166)]: - @shopify/polaris-tokens@7.8.0 - @shopify/stylelint-polaris@14.0.3 ## @shopify/stylelint-polaris@14.0.3 ### Patch Changes - Updated dependencies \[[`26ab8ce7d`](26ab8ce), [`7514dd1a3`](7514dd1), [`16c61668a`](16c6166)]: - @shopify/polaris-tokens@7.8.0 ## polaris.shopify.com@0.57.6 ### Patch Changes - Updated dependencies \[[`2e65a7e98`](2e65a7e), [`b7f25f07f`](b7f25f0), [`26ab8ce7d`](26ab8ce), [`d35d55e5b`](d35d55e), [`7514dd1a3`](7514dd1), [`16c61668a`](16c6166), [`87f559ca1`](87f559c)]: - @shopify/polaris@11.18.0 - @shopify/polaris-tokens@7.8.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…#10394) ### WHY are these changes introduced? We have some text fields across the admin that we want to disable the 1Password integration on, namely the Create new View modal within the IndexFilters component, [as seen on this ticket](Shopify/web#103483). ### WHAT is this pull request doing? This PR introduces a new prop to the TextField, named `disable1Password` which will add the `data-1p-ignore` data attribute to the input, which is the [recommended way](https://developer.1password.com/docs/web/compatible-website-design/) of disabling this functionality. ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@11.18.0 ### Minor Changes - [Shopify#10429](Shopify#10429) [`2e65a7e98`](Shopify@78e3c64) Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed `Filters` pinned filter pill not remaining when applied values are cleared - [Shopify#10394](Shopify#10394) [`b7f25f07f`](Shopify@11a5ec4) Thanks [@mrcthms](https://github.com/mrcthms)! - Added support for disabling 1Password integration in `TextField` - [Shopify#10406](Shopify#10406) [`87f559ca1`](Shopify@87ef9b6) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated the Toast component to support multiple re-renders being announced on screen readers ### Patch Changes - [Shopify#10428](Shopify#10428) [`d35d55e5b`](Shopify@ded82d4) Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed layout shift in `IndexFilters` when switching modes - Updated dependencies \[[`26ab8ce7d`](Shopify@2638248), [`7514dd1a3`](Shopify@beb664a), [`16c61668a`](Shopify@54284eb)]: - @shopify/polaris-tokens@7.8.0 ## @shopify/polaris-tokens@7.8.0 ### Minor Changes - [Shopify#10432](Shopify#10432) [`26ab8ce7d`](Shopify@2638248) Thanks [@lgriffee](https://github.com/lgriffee)! - Added public primitive `border-radius` token scale - [Shopify#10448](Shopify#10448) [`7514dd1a3`](Shopify@beb664a) Thanks [@lgriffee](https://github.com/lgriffee)! - Added public primitive `space` token scale - [Shopify#10418](Shopify#10418) [`16c61668a`](Shopify@54284eb) Thanks [@lgriffee](https://github.com/lgriffee)! - Added private primitive `size` token scale ## @shopify/polaris-migrator@0.22.3 ### Patch Changes - Updated dependencies \[[`26ab8ce7d`](Shopify@2638248), [`7514dd1a3`](Shopify@beb664a), [`16c61668a`](Shopify@54284eb)]: - @shopify/polaris-tokens@7.8.0 - @shopify/stylelint-polaris@14.0.3 ## @shopify/stylelint-polaris@14.0.3 ### Patch Changes - Updated dependencies \[[`26ab8ce7d`](Shopify@2638248), [`7514dd1a3`](Shopify@beb664a), [`16c61668a`](Shopify@54284eb)]: - @shopify/polaris-tokens@7.8.0 ## polaris.shopify.com@0.57.6 ### Patch Changes - Updated dependencies \[[`2e65a7e98`](Shopify@78e3c64), [`b7f25f07f`](Shopify@11a5ec4), [`26ab8ce7d`](Shopify@2638248), [`d35d55e5b`](Shopify@ded82d4), [`7514dd1a3`](Shopify@beb664a), [`16c61668a`](Shopify@54284eb), [`87f559ca1`](Shopify@87ef9b6)]: - @shopify/polaris@11.18.0 - @shopify/polaris-tokens@7.8.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We have some text fields across the admin that we want to disable the 1Password integration on, namely the Create new View modal within the IndexFilters component, as seen on this ticket.
WHAT is this pull request doing?
This PR introduces a new prop to the TextField, named
disable1Passwordwhich will add thedata-1p-ignoredata attribute to the input, which is the recommended way of disabling this functionality.🎩 checklist
README.mdwith documentation changes