Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Add public primitive space token scale #10448

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Add public primitive space token scale #10448

merged 2 commits into from
Sep 13, 2023

Conversation

lgriffee
Copy link
Contributor

WHY are these changes introduced?

Fixes #10435

WHAT is this pull request doing?

Adds the following values to new public primitive space token scales:

New Token Value Value (in px)
--p-space-050 size['050'] 2px
--p-space-100 size[100] 4px
--p-space-150 size[150] 6px
--p-space-200 size[200] 8px
--p-space-300 size[300] 12px
--p-space-400 size[400] 16px
--p-space-500 size[500] 20px
--p-space-600 size[600] 24px
--p-space-800 size[800] 32px
--p-space-1000 size[1000] 40px
--p-space-1200 size[1200] 48px
--p-space-1600 size[1600] 64px
--p-space-2000 size[2000] 80px
--p-space-2400 size[2400] 96px
--p-space-3200 size[3200] 128px

@lgriffee lgriffee self-assigned this Sep 13, 2023
lgriffee
lgriffee commented Sep 13, 2023
View reviewed changes
@lgriffee lgriffee merged commit 7514dd1 into main Sep 13, 2023
@lgriffee lgriffee deleted the space-tokens branch September 13, 2023 18:25
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Sep 13, 2023
Merged
@lgriffee lgriffee changed the title Add public primitive space token scales Add public primitive space token scale Sep 13, 2023
mrcthms pushed a commit that referenced this pull request Sep 14, 2023
@shopify-github-actions-access @github-actions
Version Packages (#10405)
ea93110 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@11.18.0

### Minor Changes

- [#10429](#10429)
[`2e65a7e98`](2e65a7e)
Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed `Filters` pinned
filter pill not remaining when applied values are cleared


- [#10394](#10394)
[`b7f25f07f`](b7f25f0)
Thanks [@mrcthms](https://github.com/mrcthms)! - Added support for
disabling 1Password integration in `TextField`


- [#10406](#10406)
[`87f559ca1`](87f559c)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated the Toast
component to support multiple re-renders being announced on screen
readers

### Patch Changes

- [#10428](#10428)
[`d35d55e5b`](d35d55e)
Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed layout shift in
`IndexFilters` when switching modes

- Updated dependencies
\[[`26ab8ce7d`](26ab8ce),
[`7514dd1a3`](7514dd1),
[`16c61668a`](16c6166)]:
    -   @shopify/polaris-tokens@7.8.0

## @shopify/polaris-tokens@7.8.0

### Minor Changes

- [#10432](#10432)
[`26ab8ce7d`](26ab8ce)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added public
primitive `border-radius` token scale


- [#10448](#10448)
[`7514dd1a3`](7514dd1)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added public
primitive `space` token scale


- [#10418](#10418)
[`16c61668a`](16c6166)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added private
primitive `size` token scale

## @shopify/polaris-migrator@0.22.3

### Patch Changes

- Updated dependencies
\[[`26ab8ce7d`](26ab8ce),
[`7514dd1a3`](7514dd1),
[`16c61668a`](16c6166)]:
    -   @shopify/polaris-tokens@7.8.0
    -   @shopify/stylelint-polaris@14.0.3

## @shopify/stylelint-polaris@14.0.3

### Patch Changes

- Updated dependencies
\[[`26ab8ce7d`](26ab8ce),
[`7514dd1a3`](7514dd1),
[`16c61668a`](16c6166)]:
    -   @shopify/polaris-tokens@7.8.0

## polaris.shopify.com@0.57.6

### Patch Changes

- Updated dependencies
\[[`2e65a7e98`](2e65a7e),
[`b7f25f07f`](b7f25f0),
[`26ab8ce7d`](26ab8ce),
[`d35d55e5b`](d35d55e),
[`7514dd1a3`](7514dd1),
[`16c61668a`](16c6166),
[`87f559ca1`](87f559c)]:
    -   @shopify/polaris@11.18.0
    -   @shopify/polaris-tokens@7.8.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@lgriffee
Add public primitive space token scales (Shopify#10448)
beb664a 
### WHY are these changes introduced?
Fixes Shopify#10435

### WHAT is this pull request doing?

Adds the following values to new public primitive `space` token scales: 

| New Token          | Value        | Value (in px)
| ------------------------- | ------------------------ |
------------------------ |
| `--p-space-050` | `size['050']`  | `2px`    |
| `--p-space-100` | `size[100]`  | `4px`    |
| `--p-space-150` | `size[150]`  | `6px`    |
| `--p-space-200` | `size[200]`  | `8px`    |
| `--p-space-300` | `size[300]`  | `12px`    |
| `--p-space-400` | `size[400]`  | `16px`    |
| `--p-space-500` | `size[500]`  | `20px`    |
| `--p-space-600` | `size[600]`  | `24px`    |
| `--p-space-800` | `size[800]`  | `32px`    |
| `--p-space-1000` | `size[1000]`  | `40px`    |
| `--p-space-1200` | `size[1200]`  | `48px`    |
| `--p-space-1600` | `size[1600]`  | `64px`    |
| `--p-space-2000` | `size[2000]`  | `80px`    |
| `--p-space-2400` | `size[2400]`  | `96px`    |
| `--p-space-3200` | `size[3200]`  | `128px`    |
ascherkus pushed a commit to ascherkus/polaris that referenced this pull request Feb 19, 2025
@shopify-github-actions-access @github-actions
Version Packages (Shopify#10405)
13ae0bb 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@11.18.0

### Minor Changes

- [Shopify#10429](Shopify#10429)
[`2e65a7e98`](Shopify@78e3c64)
Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed `Filters` pinned
filter pill not remaining when applied values are cleared


- [Shopify#10394](Shopify#10394)
[`b7f25f07f`](Shopify@11a5ec4)
Thanks [@mrcthms](https://github.com/mrcthms)! - Added support for
disabling 1Password integration in `TextField`


- [Shopify#10406](Shopify#10406)
[`87f559ca1`](Shopify@87ef9b6)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated the Toast
component to support multiple re-renders being announced on screen
readers

### Patch Changes

- [Shopify#10428](Shopify#10428)
[`d35d55e5b`](Shopify@ded82d4)
Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed layout shift in
`IndexFilters` when switching modes

- Updated dependencies
\[[`26ab8ce7d`](Shopify@2638248),
[`7514dd1a3`](Shopify@beb664a),
[`16c61668a`](Shopify@54284eb)]:
    -   @shopify/polaris-tokens@7.8.0

## @shopify/polaris-tokens@7.8.0

### Minor Changes

- [Shopify#10432](Shopify#10432)
[`26ab8ce7d`](Shopify@2638248)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added public
primitive `border-radius` token scale


- [Shopify#10448](Shopify#10448)
[`7514dd1a3`](Shopify@beb664a)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added public
primitive `space` token scale


- [Shopify#10418](Shopify#10418)
[`16c61668a`](Shopify@54284eb)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added private
primitive `size` token scale

## @shopify/polaris-migrator@0.22.3

### Patch Changes

- Updated dependencies
\[[`26ab8ce7d`](Shopify@2638248),
[`7514dd1a3`](Shopify@beb664a),
[`16c61668a`](Shopify@54284eb)]:
    -   @shopify/polaris-tokens@7.8.0
    -   @shopify/stylelint-polaris@14.0.3

## @shopify/stylelint-polaris@14.0.3

### Patch Changes

- Updated dependencies
\[[`26ab8ce7d`](Shopify@2638248),
[`7514dd1a3`](Shopify@beb664a),
[`16c61668a`](Shopify@54284eb)]:
    -   @shopify/polaris-tokens@7.8.0

## polaris.shopify.com@0.57.6

### Patch Changes

- Updated dependencies
\[[`2e65a7e98`](Shopify@78e3c64),
[`b7f25f07f`](Shopify@11a5ec4),
[`26ab8ce7d`](Shopify@2638248),
[`d35d55e5b`](Shopify@ded82d4),
[`7514dd1a3`](Shopify@beb664a),
[`16c61668a`](Shopify@54284eb),
[`87f559ca1`](Shopify@87ef9b6)]:
    -   @shopify/polaris@11.18.0
    -   @shopify/polaris-tokens@7.8.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@aaronccasanova aaronccasanova aaronccasanova approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lgriffee lgriffee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add public primitive space token layer
2 participants
@lgriffee @aaronccasanova