Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Conversation

jesstelford
Copy link
Contributor

@jesstelford jesstelford commented Jan 12, 2024

A continuation of #10804 to convert SASS to the PostCSS transform everywhere in @shopify/polaris:

-@media #{$p-breakpoints-md-up} {
+@media (--p-breakpoints-md-up) {

@jesstelford jesstelford force-pushed the custom-media-everywhere branch from 1a40771 to 1418bf3 Compare January 12, 2024 03:06
@jesstelford jesstelford force-pushed the custom-media-everywhere branch from 1418bf3 to 1b1ac15 Compare January 12, 2024 03:10
@jesstelford jesstelford merged commit 4353566 into main Jan 12, 2024
@jesstelford jesstelford deleted the custom-media-everywhere branch January 12, 2024 04:40
@aaronccasanova
Copy link
Member

Nice work!! It's awesome to see a vision from 2022 come to life 🚀

Design

The design of the generated media conditions is as close as I could get to the up coming @custom-media spec without introducing the postcss-custom-media plugin. [...] The hope is that this will create the most seamless upgrade path in the future when we remove these aliased media conditions in favor of CSS custom media variables e.g.

Before:

@media #{$p-breakpoints-md-up} {/*...*/}

After:

@media (--p-breakpoints-md-up) {/*...*/}

@lgriffee lgriffee added the #gsd:38846 Admin Quality Improvements (Q1 2024) label Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#gsd:38846 Admin Quality Improvements (Q1 2024)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants