Skip to content

BulkActions.tsx: deactivate popover if selectMode is false. #7578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2022
Merged

BulkActions.tsx: deactivate popover if selectMode is false. #7578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb472ae
BulkActions.tsx: deactivate popover if selectMode is false.
haskelash-shopify Oct 31, 2022
cafde8a
BulkActions.tsx: fix error of possible undefined.
haskelash-shopify Nov 2, 2022
b3c5182
Create changeset.
haskelash-shopify Nov 2, 2022
e37a36d
BulkActions.tsx: use strict equality check.
haskelash-shopify Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilled-otters-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Hide bulk actions popup when all items are deselected.
4 changes: 2 additions & 2 deletions polaris-react/src/components/BulkActions/BulkActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ class BulkActionsInner extends PureComponent<CombinedProps, State> {
const allActionsPopover = this.hasActions() ? (
<div className={styles.Popover} ref={this.setMoreActionsNode}>
<Popover
active={smallScreenPopoverVisible}
active={smallScreenPopoverVisible && selectMode === true}
activator={
<BulkActionButton
disclosure
Expand Down Expand Up @@ -372,7 +372,7 @@ class BulkActionsInner extends PureComponent<CombinedProps, State> {
actionSections || rolledInPromotedActions.length > 0 || measuring ? (
<div className={styles.Popover} ref={this.setMoreActionsNode}>
<Popover
active={largeScreenPopoverVisible}
active={largeScreenPopoverVisible && selectMode === true}
activator={
<BulkActionButton
disclosure
Expand Down