Skip to content

Fix Bleed regressions #7705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Fix Bleed regressions #7705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion polaris-react/src/components/Banner/Banner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ export const Banner = forwardRef<BannerHandles, BannerProps>(function Banner(
<Icon source={iconName} color={iconColor} />
</Box>

<Bleed top="05">
<Bleed horizontal="0" top="05">
{headingMarkup}
{contentMarkup}
</Bleed>
Expand Down
4 changes: 2 additions & 2 deletions polaris-react/src/components/Bleed/Bleed.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function Default() {
export function WithVerticalDirection() {
return (
<Box background="surface" padding="4">
<Bleed vertical="6">
<Bleed horizontal="0" vertical="6">
<div style={styles} />
</Bleed>
</Box>
Expand All @@ -54,7 +54,7 @@ export function WithHorizontalDirection() {
export function WithSpecificDirection() {
return (
<Box background="surface" padding="4">
<Bleed top="6">
<Bleed horizontal="0" top="6">
<div style={styles} />
</Bleed>
</Box>
Expand Down
8 changes: 4 additions & 4 deletions polaris.shopify.com/pages/examples/bleed-specific-direction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,22 @@ function BleedSpecificDirectionExample() {
return (
<AlphaStack spacing="6" fullWidth>
<Box background="surface" border="base" padding="4">
<Bleed top="4">
<Bleed horizontal="0" top="4">
<Placeholder label="Top" />
</Bleed>
</Box>
<Box background="surface" border="base" padding="4">
<Bleed bottom="4">
<Bleed horizontal="0" bottom="4">
<Placeholder label="Bottom" />
</Bleed>
</Box>
<Box background="surface" border="base" padding="4">
<Bleed left="4">
<Bleed horizontal="0" left="4">
<Placeholder label="Left" />
</Bleed>
</Box>
<Box background="surface" border="base" padding="4">
<Bleed right="4">
<Bleed horizontal="0" right="4">
<Placeholder label="Right" />
</Bleed>
</Box>
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/bleed-vertical.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';
function BleedVerticalExample() {
return (
<Box background="surface" border="base" padding="4">
<Bleed vertical="4">
<Bleed horizontal="0" vertical="4">
<Placeholder label="Vertical" />
</Bleed>
</Box>
Expand Down