Fix Bleed regressions
#7705
Fix Bleed regressions
#7705
Conversation
size-limit report 📦
|
kyledurand
requested review from
chazdean,
laurkim and
aveline
and removed request for
chazdean and
laurkim
There was a problem hiding this comment.
I still think it's an odd pattern to have to set ="0"s if the defaults don't suit. I think defaults are good if they get silently overridden.
If we still need to figure out the correct defaults, maybe better to leave them off for now? Once we get more usage of Bleed we can see what the most common values are and use that to inform the defaults.
|
I don't see any point in holding off for now. We're going to ship these components with opinions. They may be wrong right now but we can change them in the future |
There was a problem hiding this comment.
I'm okay with this approach because I think it may fix broken bleed examples on the style guide as well. As we continue to rebuild internal components, we can discuss more in detail whether we want to keep the approach of adding props with the 0 value or remove it. Given that it's still in the alpha phase, I think we should ship this approach and continue iterating in subsequent PRs.
|
Going to ship this but please keep sharing the pain points, it's how we learn and get better ❤️ |
I'm still of the opinion that our layout components should have some defaults and the ones we have on bleed may not be right but we need to use it in more places to figure out what those defaults should be. For now, this fixes regressions to Banner that were introduced in #7644
I'm still of the opinion that our layout components should have some defaults and the ones we have on bleed may not be right but we need to use it in more places to figure out what those defaults should be. For now, this fixes regressions to Banner that were introduced in #7644
I'm still of the opinion that our layout components should have some defaults and the ones we have on bleed may not be right but we need to use it in more places to figure out what those defaults should be. For now, this fixes regressions to Banner that were introduced in #7644
I'm still of the opinion that our layout components should have some defaults and the ones we have on bleed may not be right but we need to use it in more places to figure out what those defaults should be. For now, this fixes regressions to Banner that were introduced in #7644
I'm still of the opinion that our layout components should have some defaults and the ones we have on bleed may not be right but we need to use it in more places to figure out what those defaults should be. For now, this fixes regressions to Banner that were introduced in #7644
I'm still of the opinion that our layout components should have some defaults and the ones we have on bleed may not be right but we need to use it in more places to figure out what those defaults should be.
For now, this fixes regressions to Banner that were introduced in #7644