Skip to content

Disallow text transform in stylelint-polaris coverage rules #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Disallow text transform in stylelint-polaris coverage rules #8244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e3100b
Disallow text transform in stylelint-polaris coverage rules
sam-b-rose Feb 2, 2023
cd0817e
Insert disable comments
sam-b-rose Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/metal-queens-look.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@shopify/stylelint-polaris': minor
'@shopify/polaris': patch
---

Disallow text-transform property in Stylelint Polaris
1 change: 1 addition & 0 deletions polaris-react/src/components/AppProvider/AppProvider.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ body {
line-height: var(--p-font-line-height-2);
font-weight: var(--p-font-weight-regular);

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;

Expand Down
1 change: 1 addition & 0 deletions polaris-react/src/components/Banner/Banner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@
font-size: var(--p-font-size-100);
font-weight: var(--p-font-weight-medium);
line-height: var(--p-font-line-height-1);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;
color: var(--p-text);
Expand Down
2 changes: 2 additions & 0 deletions polaris-react/src/components/Button/Button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
font-size: var(--p-font-size-100);
font-weight: var(--p-font-weight-medium);
line-height: var(--p-font-line-height-1);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
Expand Down Expand Up @@ -463,6 +464,7 @@
font-size: var(--p-font-size-200);
font-weight: var(--p-font-weight-medium);
line-height: var(--p-font-line-height-2);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;
}
Expand Down
1 change: 1 addition & 0 deletions polaris-react/src/components/CheckableButton/CheckableButton.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
font-size: var(--p-font-size-75);
font-weight: var(--p-font-weight-medium);
line-height: var(--p-font-line-height-1);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
Expand Down
1 change: 1 addition & 0 deletions polaris-react/src/components/FooterHelp/FooterHelp.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
font-weight: var(--p-font-weight-regular);
line-height: var(--p-font-line-height-2);
border: none;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;
}
1 change: 1 addition & 0 deletions polaris-react/src/components/Frame/Frame.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@
font-size: var(--p-font-size-100);
font-weight: var(--p-font-weight-medium);
line-height: var(--p-font-line-height-1);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;
color: var(--p-text);
Expand Down
1 change: 1 addition & 0 deletions polaris-react/src/components/Navigation/Navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,7 @@ $disabled-fade: 0.6;
}

.SectionHeading {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: none; // Adding this intentionally to override the default subheading styling.
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
Expand Down
1 change: 1 addition & 0 deletions polaris-react/src/components/Select/Select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
font-size: var(--p-font-size-200);
font-weight: var(--p-font-weight-regular);
line-height: var(--p-font-line-height-2);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
Expand Down
1 change: 1 addition & 0 deletions polaris-react/src/components/TextField/TextField.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ $spinner-icon-size: 12px;
font-size: var(--p-font-size-200);
font-weight: var(--p-font-weight-regular);
line-height: var(--p-font-line-height-2);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
Expand Down
5 changes: 5 additions & 0 deletions polaris-react/src/styles/shared/_typography.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
font-size: 13px;
font-weight: var(--p-font-weight-semibold);
line-height: var(--p-font-line-height-1);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: uppercase;

@media #{$p-breakpoints-md-up} {
Expand All @@ -39,6 +40,7 @@
line-height: var(--p-font-line-height-3);
border: none;

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;

Expand All @@ -53,6 +55,7 @@
font-weight: var(--p-font-weight-regular);
line-height: var(--p-font-line-height-2);

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;

Expand All @@ -67,6 +70,7 @@
font-weight: var(--p-font-weight-medium);
line-height: var(--p-font-line-height-1);

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;

Expand All @@ -81,6 +85,7 @@
font-weight: var(--p-font-weight-medium);
line-height: var(--p-font-line-height-2);

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
text-transform: initial;
letter-spacing: initial;

Expand Down
1 change: 1 addition & 0 deletions stylelint-polaris/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ const stylelintPolarisCoverageOptions = {
'line-height': ['px', 'rem', 'em'],
},
],
'property-disallowed-list': ['text-transform'],
'function-disallowed-list': [
'font-family',
'font-size',
Expand Down