Disallow text transform in stylelint-polaris coverage rules #8244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex-page we can scope the changes to only inserting the disable comments if that is preferred for now. I have two commits, one with the disable comments and the latest with the text-transform styles removed. If we think the disable comments is the way to go, we can revert this commit |
size-limit report 📦
|
alex-page
reviewed
Feb 2, 2023
alex-page
approved these changes
Feb 2, 2023
sam-b-rose
force-pushed
the
8241-disallow-text-transform
branch
from
5b77dff to
cd0817e
Compare
Merged
laurkim
pushed a commit
that referenced
this pull request
Feb 3, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.26.0 ### Minor Changes - [#8240](#8240) [`31abdab37`](31abdab) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack` component - [#8238](#8238) [`bb8b551d4`](bb8b551) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard` component ### Patch Changes - [#8256](#8256) [`43776be71`](43776be) Thanks [@aveline](https://github.com/aveline)! - - Fixed `Bleed` width behavior - Fixed `Banner` content width - [#8244](#8244) [`0ee432500`](0ee4325) Thanks [@samrose3](https://github.com/samrose3)! - Disallow text-transform property in Stylelint Polaris - Updated dependencies \[[`1b1394d32`](1b1394d)]: - @shopify/polaris-tokens@6.4.0 ## @shopify/polaris-tokens@6.4.0 ### Minor Changes - [#8245](#8245) [`1b1394d32`](1b1394d) Thanks [@lgriffee](https://github.com/lgriffee)! - Added new z-index tokens that will be the default in v7.0.0 ## @shopify/stylelint-polaris@5.2.0 ### Minor Changes - [#8244](#8244) [`0ee432500`](0ee4325) Thanks [@samrose3](https://github.com/samrose3)! - Disallow text-transform property in Stylelint Polaris ### Patch Changes - Updated dependencies \[[`1b1394d32`](1b1394d)]: - @shopify/polaris-tokens@6.4.0 ## @shopify/polaris-cli@0.1.2 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.11.4 ## @shopify/polaris-migrator@0.11.4 ### Patch Changes - Updated dependencies \[[`1b1394d32`](1b1394d), [`0ee432500`](0ee4325)]: - @shopify/polaris-tokens@6.4.0 - @shopify/stylelint-polaris@5.2.0 ## polaris.shopify.com@0.32.0 ### Minor Changes - [#8240](#8240) [`31abdab37`](31abdab) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack` component - [#8238](#8238) [`bb8b551d4`](bb8b551) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard` component ### Patch Changes - Updated dependencies \[[`43776be71`](43776be), [`31abdab37`](31abdab), [`1b1394d32`](1b1394d), [`0ee432500`](0ee4325), [`bb8b551d4`](bb8b551)]: - @shopify/polaris@10.26.0 - @shopify/polaris-tokens@6.4.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
…8244) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes Shopify#8241 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> Adds the `text-transform` to the disallow properties list of the `stylelint-polaris` plugin.
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.26.0 ### Minor Changes - [Shopify#8240](Shopify#8240) [`31abdab37`](Shopify@31abdab) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack` component - [Shopify#8238](Shopify#8238) [`bb8b551d4`](Shopify@bb8b551) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard` component ### Patch Changes - [Shopify#8256](Shopify#8256) [`43776be71`](Shopify@43776be) Thanks [@aveline](https://github.com/aveline)! - - Fixed `Bleed` width behavior - Fixed `Banner` content width - [Shopify#8244](Shopify#8244) [`0ee432500`](Shopify@0ee4325) Thanks [@samrose3](https://github.com/samrose3)! - Disallow text-transform property in Stylelint Polaris - Updated dependencies \[[`1b1394d32`](Shopify@1b1394d)]: - @shopify/polaris-tokens@6.4.0 ## @shopify/polaris-tokens@6.4.0 ### Minor Changes - [Shopify#8245](Shopify#8245) [`1b1394d32`](Shopify@1b1394d) Thanks [@lgriffee](https://github.com/lgriffee)! - Added new z-index tokens that will be the default in v7.0.0 ## @shopify/stylelint-polaris@5.2.0 ### Minor Changes - [Shopify#8244](Shopify#8244) [`0ee432500`](Shopify@0ee4325) Thanks [@samrose3](https://github.com/samrose3)! - Disallow text-transform property in Stylelint Polaris ### Patch Changes - Updated dependencies \[[`1b1394d32`](Shopify@1b1394d)]: - @shopify/polaris-tokens@6.4.0 ## @shopify/polaris-cli@0.1.2 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.11.4 ## @shopify/polaris-migrator@0.11.4 ### Patch Changes - Updated dependencies \[[`1b1394d32`](Shopify@1b1394d), [`0ee432500`](Shopify@0ee4325)]: - @shopify/polaris-tokens@6.4.0 - @shopify/stylelint-polaris@5.2.0 ## polaris.shopify.com@0.32.0 ### Minor Changes - [Shopify#8240](Shopify#8240) [`31abdab37`](Shopify@31abdab) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack` component - [Shopify#8238](Shopify#8238) [`bb8b551d4`](Shopify@bb8b551) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard` component ### Patch Changes - Updated dependencies \[[`43776be71`](Shopify@43776be), [`31abdab37`](Shopify@31abdab), [`1b1394d32`](Shopify@1b1394d), [`0ee432500`](Shopify@0ee4325), [`bb8b551d4`](Shopify@bb8b551)]: - @shopify/polaris@10.26.0 - @shopify/polaris-tokens@6.4.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #8241
WHAT is this pull request doing?
Adds the
text-transformto the disallow properties list of thestylelint-polarisplugin.