Skip to content

Conversation

aveline
Copy link
Contributor

@aveline aveline commented Feb 2, 2023

WHY are these changes introduced?

Fixes some unexpected behaviour with the Bleed component content width
Fixes layout of content section of Banner

WHAT is this pull request doing?

Content inside Banner shouldn't extend past the intended content area

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

size-limit report 📦

Path Size
polaris-react-cjs 216.21 KB (+0.01% 🔺)
polaris-react-esm 137.48 KB (+0.01% 🔺)
polaris-react-esnext 191.34 KB (+0.02% 🔺)
polaris-react-css 40.73 KB (+0.04% 🔺)

@aveline aveline requested a review from laurkim February 2, 2023 23:58
@aveline aveline changed the title [Bleed] Fix width issue [Banner] Fix content size Feb 2, 2023
@aveline aveline marked this pull request as ready for review February 3, 2023 00:01
@aveline aveline merged commit 43776be into main Feb 3, 2023
@aveline aveline deleted the layout-bleed-fix branch February 3, 2023 15:00
laurkim pushed a commit that referenced this pull request Feb 3, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@10.26.0

### Minor Changes

- [#8240](#8240)
[`31abdab37`](31abdab)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack`
component


- [#8238](#8238)
[`bb8b551d4`](bb8b551)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard`
component

### Patch Changes

- [#8256](#8256)
[`43776be71`](43776be)
Thanks [@aveline](https://github.com/aveline)! - - Fixed `Bleed` width
behavior
    -   Fixed `Banner` content width


- [#8244](#8244)
[`0ee432500`](0ee4325)
Thanks [@samrose3](https://github.com/samrose3)! - Disallow
text-transform property in Stylelint Polaris

- Updated dependencies
\[[`1b1394d32`](1b1394d)]:
    -   @shopify/polaris-tokens@6.4.0

## @shopify/polaris-tokens@6.4.0

### Minor Changes

- [#8245](#8245)
[`1b1394d32`](1b1394d)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added new z-index
tokens that will be the default in v7.0.0

## @shopify/stylelint-polaris@5.2.0

### Minor Changes

- [#8244](#8244)
[`0ee432500`](0ee4325)
Thanks [@samrose3](https://github.com/samrose3)! - Disallow
text-transform property in Stylelint Polaris

### Patch Changes

- Updated dependencies
\[[`1b1394d32`](1b1394d)]:
    -   @shopify/polaris-tokens@6.4.0

## @shopify/polaris-cli@0.1.2

### Patch Changes

-   Updated dependencies \[]:
    -   @shopify/polaris-migrator@0.11.4

## @shopify/polaris-migrator@0.11.4

### Patch Changes

- Updated dependencies
\[[`1b1394d32`](1b1394d),
[`0ee432500`](0ee4325)]:
    -   @shopify/polaris-tokens@6.4.0
    -   @shopify/stylelint-polaris@5.2.0

## polaris.shopify.com@0.32.0

### Minor Changes

- [#8240](#8240)
[`31abdab37`](31abdab)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack`
component


- [#8238](#8238)
[`bb8b551d4`](bb8b551)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard`
component

### Patch Changes

- Updated dependencies
\[[`43776be71`](43776be),
[`31abdab37`](31abdab),
[`1b1394d32`](1b1394d),
[`0ee432500`](0ee4325),
[`bb8b551d4`](bb8b551)]:
    -   @shopify/polaris@10.26.0
    -   @shopify/polaris-tokens@6.4.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gwyneplaine gwyneplaine mentioned this pull request Feb 14, 2023
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
### WHY are these changes introduced?

Fixes some unexpected behaviour with the `Bleed` component content width

### WHAT is this pull request doing?

Content inside `Bleed` shouldn't extend past the intended content area
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@10.26.0

### Minor Changes

- [Shopify#8240](Shopify#8240)
[`31abdab37`](Shopify@31abdab)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack`
component


- [Shopify#8238](Shopify#8238)
[`bb8b551d4`](Shopify@bb8b551)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard`
component

### Patch Changes

- [Shopify#8256](Shopify#8256)
[`43776be71`](Shopify@43776be)
Thanks [@aveline](https://github.com/aveline)! - - Fixed `Bleed` width
behavior
    -   Fixed `Banner` content width


- [Shopify#8244](Shopify#8244)
[`0ee432500`](Shopify@0ee4325)
Thanks [@samrose3](https://github.com/samrose3)! - Disallow
text-transform property in Stylelint Polaris

- Updated dependencies
\[[`1b1394d32`](Shopify@1b1394d)]:
    -   @shopify/polaris-tokens@6.4.0

## @shopify/polaris-tokens@6.4.0

### Minor Changes

- [Shopify#8245](Shopify#8245)
[`1b1394d32`](Shopify@1b1394d)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added new z-index
tokens that will be the default in v7.0.0

## @shopify/stylelint-polaris@5.2.0

### Minor Changes

- [Shopify#8244](Shopify#8244)
[`0ee432500`](Shopify@0ee4325)
Thanks [@samrose3](https://github.com/samrose3)! - Disallow
text-transform property in Stylelint Polaris

### Patch Changes

- Updated dependencies
\[[`1b1394d32`](Shopify@1b1394d)]:
    -   @shopify/polaris-tokens@6.4.0

## @shopify/polaris-cli@0.1.2

### Patch Changes

-   Updated dependencies \[]:
    -   @shopify/polaris-migrator@0.11.4

## @shopify/polaris-migrator@0.11.4

### Patch Changes

- Updated dependencies
\[[`1b1394d32`](Shopify@1b1394d),
[`0ee432500`](Shopify@0ee4325)]:
    -   @shopify/polaris-tokens@6.4.0
    -   @shopify/stylelint-polaris@5.2.0

## polaris.shopify.com@0.32.0

### Minor Changes

- [Shopify#8240](Shopify#8240)
[`31abdab37`](Shopify@31abdab)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack`
component


- [Shopify#8238](Shopify#8238)
[`bb8b551d4`](Shopify@bb8b551)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard`
component

### Patch Changes

- Updated dependencies
\[[`43776be71`](Shopify@43776be),
[`31abdab37`](Shopify@31abdab),
[`1b1394d32`](Shopify@1b1394d),
[`0ee432500`](Shopify@0ee4325),
[`bb8b551d4`](Shopify@bb8b551)]:
    -   @shopify/polaris@10.26.0
    -   @shopify/polaris-tokens@6.4.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants