-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Text] Update headingXs variant to use semibold instead of bold #7179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aveline
approved these changes
Sep 14, 2022
size-limit report 📦
|
f481f1f to
3a0699f
Compare
sarahill
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Merged
laurkim
added a commit
that referenced
this pull request
Sep 15, 2022
### WHY are these changes introduced? Resolves #7169. Updates the `headingXs` variant to use `semibold` instead of `bold`. ### WHAT is this pull request doing? Updates the variant font mapping to use `semibold` for the `headingXs` variant. <details> <summary>Text headingXs variant before</summary> <img src="https://user-images.githubusercontent.com/26749317/190215333-2ecc0470-65ff-4753-ba44-866c7223e7ea.png" alt="Text headingXs variant before"> </details> <details> <summary>Text headingXs variant after</summary> <img src="https://user-images.githubusercontent.com/26749317/190215326-cdd4a150-a18b-4b0c-a11c-05086354dff9.png" alt="Text headingXs variant after"> </details> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page, Text} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} <Text as="h6" variant="headingXs"> Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam ac convallis nulla, mollis sagittis est. Phasellus condimentum diam magna, et viverra sapien fringilla sed. </Text> </Page> ); } ``` </details> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
sam-b-rose
pushed a commit
that referenced
this pull request
Sep 15, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.2.0 ### Minor Changes - [#7128](#7128) [`9d6497970`](9d64979) Thanks [@james-a-c](https://github.com/james-a-c)! - Add new icon `FilterMinor` ## @shopify/polaris-migrator@0.1.0 ### Minor Changes - [#7153](#7153) [`17d5bd0e8`](17d5bd0) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Add migration for legacy static breakpoint mixins ## @shopify/polaris@10.3.0 ### Minor Changes - [#7181](#7181) [`577796691`](5777966) Thanks [@laurkim](https://github.com/laurkim)! - Added stories for `Text` component - [#7140](#7140) [`9eff83ea6`](9eff83e) Thanks [@renerbaffa](https://github.com/renerbaffa)! - Export hexToRgb from color-transformers - [#7050](#7050) [`0ccc981fc`](0ccc981) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Exposes useBreakpoint as a named export from @shopify/polaris-react - [#7178](#7178) [`2ce4503f5`](2ce4503) Thanks [@IrinaLipovaya](https://github.com/IrinaLipovaya)! - Add `ariaLabelledBy` prop to `ProgressBar` component to allow ids of description elements for accessibility ### Patch Changes - [#7132](#7132) [`c31402639`](c314026) Thanks [@martenbjork](https://github.com/martenbjork)! - Clarified the naming of SkeletonTabs props (from "Props" to "SkeletonTabsProps") - [#7141](#7141) [`8e16d15d1`](8e16d15) Thanks [@renerbaffa](https://github.com/renerbaffa)! - Added an example of Hex code TextField to ColorPicker - [#7179](#7179) [`3911a45a8`](3911a45) Thanks [@laurkim](https://github.com/laurkim)! - Updated `Text` component to use `semibold` for `headingXs` variant - [#7111](#7111) [`69faaa41d`](69faaa4) Thanks [@nneubarth](https://github.com/nneubarth)! - Fixed bug in which deleted elements or clicks inside other portal-based elements were inappropriately closing popovers - Updated dependencies \[[`9d6497970`](9d64979)]: - @shopify/polaris-icons@6.2.0 ## @shopify/plugin-polaris@0.0.1 ### Patch Changes - [#7166](#7166) [`1a3d54dc3`](1a3d54d) Thanks [@samrose3](https://github.com/samrose3)! - Initial release 🚀 - Updated dependencies \[[`17d5bd0e8`](17d5bd0)]: - @shopify/polaris-migrator@0.1.0 ## polaris-for-figma@0.0.15 ### Patch Changes - Updated dependencies \[[`c31402639`](c314026), [`577796691`](5777966), [`8e16d15d1`](8e16d15), [`9eff83ea6`](9eff83e), [`0ccc981fc`](0ccc981), [`3911a45a8`](3911a45), [`69faaa41d`](69faaa4), [`2ce4503f5`](2ce4503)]: - @shopify/polaris@10.3.0 ## polaris.shopify.com@0.17.1 ### Patch Changes - [#7050](#7050) [`0ccc981fc`](0ccc981) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Fix data-table with-fixed-first-columns example referencing useMedia hook. Replace with useBreakpoint export from polaris-react - [#7177](#7177) [`b79e64e2c`](b79e64e) Thanks [@sarahill](https://github.com/sarahill)! - Updated typography guidance to clarify number alignment - Updated dependencies \[[`c31402639`](c314026), [`577796691`](5777966), [`8e16d15d1`](8e16d15), [`9d6497970`](9d64979), [`9eff83ea6`](9eff83e), [`0ccc981fc`](0ccc981), [`3911a45a8`](3911a45), [`69faaa41d`](69faaa4), [`2ce4503f5`](2ce4503)]: - @shopify/polaris@10.3.0 - @shopify/polaris-icons@6.2.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #7169.
Updates the
headingXsvariant to usesemiboldinstead ofbold.WHAT is this pull request doing?
Updates the variant font mapping to use
semiboldfor theheadingXsvariant.Text headingXs variant before
Text headingXs variant after
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes