Skip to content

Conversation

@laurkim
Copy link
Contributor

@laurkim laurkim commented Sep 14, 2022

WHY are these changes introduced?

Resolves #7169.
Updates the headingXs variant to use semibold instead of bold.

WHAT is this pull request doing?

Updates the variant font mapping to use semibold for the headingXs variant.


Text headingXs variant before
Text headingXs variant before


Text headingXs variant after
Text headingXs variant after

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';

import {Page, Text} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
      <Text as="h6" variant="headingXs">
        Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam ac
        convallis nulla, mollis sagittis est. Phasellus condimentum diam magna,
        et viverra sapien fringilla sed.
      </Text>
    </Page>
  );
}

🎩 checklist

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

size-limit report 📦

Path Size
polaris-react-cjs 202.08 KB (-0.01% 🔽)
polaris-react-esm 129.31 KB (-0.01% 🔽)
polaris-react-esnext 183.43 KB (-0.01% 🔽)
polaris-react-css 40.62 KB (0%)

@laurkim laurkim force-pushed the lo/update-text-headingxs-variant branch from f481f1f to 3a0699f Compare September 14, 2022 17:02
Copy link
Contributor

@sarahill sarahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@laurkim laurkim merged commit 3911a45 into main Sep 14, 2022
@laurkim laurkim deleted the lo/update-text-headingxs-variant branch September 14, 2022 17:15
@github-actions github-actions bot mentioned this pull request Sep 14, 2022
laurkim added a commit that referenced this pull request Sep 15, 2022
### WHY are these changes introduced?

Resolves #7169.
Updates the `headingXs` variant to use `semibold` instead of `bold`.

### WHAT is this pull request doing?

Updates the variant font mapping to use `semibold` for the `headingXs`
variant.
    <details>
      <summary>Text headingXs variant before</summary>
<img
src="https://user-images.githubusercontent.com/26749317/190215333-2ecc0470-65ff-4753-ba44-866c7223e7ea.png"
alt="Text headingXs variant before">
    </details>
    <details>
      <summary>Text headingXs variant after</summary>
<img
src="https://user-images.githubusercontent.com/26749317/190215326-cdd4a150-a18b-4b0c-a11c-05086354dff9.png"
alt="Text headingXs variant after">
    </details>

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';

import {Page, Text} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
      <Text as="h6" variant="headingXs">
        Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam ac
        convallis nulla, mollis sagittis est. Phasellus condimentum diam magna,
        et viverra sapien fringilla sed.
      </Text>
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [x] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
sam-b-rose pushed a commit that referenced this pull request Sep 15, 2022
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@6.2.0

### Minor Changes

- [#7128](#7128)
[`9d6497970`](9d64979)
Thanks [@james-a-c](https://github.com/james-a-c)! - Add new icon
`FilterMinor`

## @shopify/polaris-migrator@0.1.0

### Minor Changes

- [#7153](#7153)
[`17d5bd0e8`](17d5bd0)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Add
migration for legacy static breakpoint mixins

## @shopify/polaris@10.3.0

### Minor Changes

- [#7181](#7181)
[`577796691`](5777966)
Thanks [@laurkim](https://github.com/laurkim)! - Added stories for
`Text` component


- [#7140](#7140)
[`9eff83ea6`](9eff83e)
Thanks [@renerbaffa](https://github.com/renerbaffa)! - Export hexToRgb
from color-transformers


- [#7050](#7050)
[`0ccc981fc`](0ccc981)
Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Exposes
useBreakpoint as a named export from @shopify/polaris-react


- [#7178](#7178)
[`2ce4503f5`](2ce4503)
Thanks [@IrinaLipovaya](https://github.com/IrinaLipovaya)! - Add
`ariaLabelledBy` prop to `ProgressBar` component to allow ids of
description elements for accessibility

### Patch Changes

- [#7132](#7132)
[`c31402639`](c314026)
Thanks [@martenbjork](https://github.com/martenbjork)! - Clarified the
naming of SkeletonTabs props (from "Props" to "SkeletonTabsProps")


- [#7141](#7141)
[`8e16d15d1`](8e16d15)
Thanks [@renerbaffa](https://github.com/renerbaffa)! - Added an example
of Hex code TextField to ColorPicker


- [#7179](#7179)
[`3911a45a8`](3911a45)
Thanks [@laurkim](https://github.com/laurkim)! - Updated `Text`
component to use `semibold` for `headingXs` variant


- [#7111](#7111)
[`69faaa41d`](69faaa4)
Thanks [@nneubarth](https://github.com/nneubarth)! - Fixed bug in which
deleted elements or clicks inside other portal-based elements were
inappropriately closing popovers

- Updated dependencies
\[[`9d6497970`](9d64979)]:
    -   @shopify/polaris-icons@6.2.0

## @shopify/plugin-polaris@0.0.1

### Patch Changes

- [#7166](#7166)
[`1a3d54dc3`](1a3d54d)
Thanks [@samrose3](https://github.com/samrose3)! - Initial release 🚀

- Updated dependencies
\[[`17d5bd0e8`](17d5bd0)]:
    -   @shopify/polaris-migrator@0.1.0

## polaris-for-figma@0.0.15

### Patch Changes

- Updated dependencies
\[[`c31402639`](c314026),
[`577796691`](5777966),
[`8e16d15d1`](8e16d15),
[`9eff83ea6`](9eff83e),
[`0ccc981fc`](0ccc981),
[`3911a45a8`](3911a45),
[`69faaa41d`](69faaa4),
[`2ce4503f5`](2ce4503)]:
    -   @shopify/polaris@10.3.0

## polaris.shopify.com@0.17.1

### Patch Changes

- [#7050](#7050)
[`0ccc981fc`](0ccc981)
Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Fix data-table
with-fixed-first-columns example referencing useMedia hook. Replace with
useBreakpoint export from polaris-react


- [#7177](#7177)
[`b79e64e2c`](b79e64e)
Thanks [@sarahill](https://github.com/sarahill)! - Updated typography
guidance to clarify number alignment

- Updated dependencies
\[[`c31402639`](c314026),
[`577796691`](5777966),
[`8e16d15d1`](8e16d15),
[`9d6497970`](9d64979),
[`9eff83ea6`](9eff83e),
[`0ccc981fc`](0ccc981),
[`3911a45a8`](3911a45),
[`69faaa41d`](69faaa4),
[`2ce4503f5`](2ce4503)]:
    -   @shopify/polaris@10.3.0
    -   @shopify/polaris-icons@6.2.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Typography foundations] [Migration] Update the font weight of HeadingXs from bold to semibold

3 participants