fix(🐛): fix memory error in animated Box shadows #3366
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a memory error in animated Box shadows by optimizing the way shadow objects are created and stored in the vector. The fix addresses issue #3365 by eliminating unnecessary object copying during shadow processing.
- Replaces
push_backwithemplace_backto construct shadow objects directly in the vector - Uses a reference to the emplaced object to avoid creating temporary objects
- Removes an unnecessary comment line
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // Create shadow directly in vector to avoid copy | ||
| shadows.emplace_back(); | ||
| BoxShadowCmdProps &shadow = shadows.back(); |
There was a problem hiding this comment.
The comment mentions avoiding copy, but this approach still creates a default-constructed object then modifies it. Consider using emplace_back with direct initialization of the struct members to truly avoid intermediate object creation.
Copilot uses AI. Check for mistakes.
|
🎉 This PR is included in version 2.2.14 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
fixes #3365