Skip to content

fix(🐎): fix Reanimated ArrayBuffer unmarshalling #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2025
Merged

fix(🐎): fix Reanimated ArrayBuffer unmarshalling #3384

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45e4d53
fix(🐎): fix Reanimated ArrayBuffer unmarshalling
wcandillon Sep 18, 2025
7a9b15c
fix(🐎): fix Reanimated ArrayBuffer unmarshalling
wcandillon Sep 18, 2025
a99f59b
Merge branch 'main' into fix-color-buffer
wcandillon Sep 18, 2025
2f7a863
Update packages/skia/cpp/api/recorder/Convertor.h
wcandillon Sep 18, 2025
e9e1f08
Update packages/skia/cpp/api/recorder/Convertor.h
wcandillon Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/skia/cpp/api/recorder/Convertor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,22 @@ SkColor getPropertyValue(jsi::Runtime &runtime, const jsi::Value &value) {
auto a = array.getValueAtIndex(runtime, 3).asNumber();
return SkColorSetARGB(a * 255, r * 255, g * 255, b * 255);
}

// Check for properties "0", "1", "2", "3" (even if not an array)
auto prop0 = jsi::PropNameID::forAscii(runtime, "0");
auto prop1 = jsi::PropNameID::forAscii(runtime, "1");
auto prop2 = jsi::PropNameID::forAscii(runtime, "2");
auto prop3 = jsi::PropNameID::forAscii(runtime, "3");
if (object.hasProperty(runtime, prop0) &&
object.hasProperty(runtime, prop1) &&
object.hasProperty(runtime, prop2) &&
object.hasProperty(runtime, prop3)) {
auto r = object.getProperty(runtime, prop0).asNumber();
auto g = object.getProperty(runtime, prop1).asNumber();
auto b = object.getProperty(runtime, prop2).asNumber();
auto a = object.getProperty(runtime, prop3).asNumber();
return SkColorSetARGB(a * 255, r * 255, g * 255, b * 255);
}
jsi::ArrayBuffer buffer =
object
.getProperty(runtime, jsi::PropNameID::forAscii(runtime, "buffer"))
Expand Down
Loading