Skip to content

fix(🌎): fix useSVG bug on web #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

fix(🌎): fix useSVG bug on web #3408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/skia/src/skia/core/SVG.web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,18 @@ export const useSVG = (
if (source === null || source === undefined) {
throw new Error(`Invalid svg data source. Got: ${source}`);
}
if (
typeof source !== "object" ||
source instanceof Uint8Array ||
!("uri" in source) ||
typeof source.uri !== "string" ||
!("default" in source) ||
typeof source.default !== "string"
let src: string;
if (typeof source === "string") {
src = source;
} else if (
typeof source === "object" &&
"default" in source &&
typeof source.default === "string"
) {
src = source.default;
} else if (typeof source === "object" && "uri" in source) {
src = source.uri;
} else {
throw new Error(
`Invalid svg data source. Make sure that the source resolves to a string. Got: ${JSON.stringify(
source,
Expand All @@ -24,7 +28,7 @@ export const useSVG = (
)}`
);
}
const svg = Skia.SVG.MakeFromString(source.default);
const svg = Skia.SVG.MakeFromString(src);
if (svg === null && onError !== undefined) {
onError(new Error("Failed to create SVG from source."));
}
Expand Down
Loading