Melaniewpaulinak/add fulfillment event #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mllemango
commented
Jan 29, 2021
|
|
||
| def save(self): | ||
| status = self.attributes['status'] | ||
| if status not in ['label_printed', 'label_purchased', 'attempted_delivery', 'ready_for_pickup', 'picked_up', 'confirmed', 'in_transit', 'out_for_delivery', 'delivered', 'failure']: |
There was a problem hiding this comment.
Unsure if hardcoding a list of accepted status' is the best way to go about this
There was a problem hiding this comment.
As for whether to hard code them: Are these likely to change in the future at all/frequently? And is there another way to reference them?
There was a problem hiding this comment.
No other way to reference status as far as I know
There was a problem hiding this comment.
Yeah I didn't think so, but wanted to ask. I would maybe just assign a variable for the array but otherwise if that's the only option, that's the only option 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #361
WHAT is this pull request doing?
Introducing new resource FulfillmentEvent that maps to the fulfillment_event api https://shopify.dev/docs/admin-api/rest/reference/shipping-and-fulfillment/fulfillmentevent
Checklist