Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

SLATE_IGNORE_FILES does not work #702

Closed
raymondmatthew opened this issue Aug 13, 2018 · 6 comments
Closed

SLATE_IGNORE_FILES does not work #702

raymondmatthew opened this issue Aug 13, 2018 · 6 comments
Assignees

Comments

@raymondmatthew
Copy link

Problem

SLATE_IGNORE_FILES does not ignore my files

Replication steps

add this to your .env
SLATE_IGNORE_FILES=/config/settings_data.json:/assets/static/icons.svg

More Information

I want to ignore my icons.svg as whenever I deploy my work the icons.svg wont work properly so I have to upload it to the store directly whenever I deploy

am I writing the proper syntax?

@artshostak
Copy link

Same issue, it's only ignoring the first file listed.

@jonathanmoore
Copy link
Contributor

@arthurgouveia for your second file are you also trying to ignore a file in the assets folder?

This did work for me successfully:
SLATE_IGNORE_FILES=/config/settings_data.json:/layout/theme.liquid

@raymondmatthew
Copy link
Author

@jonathanmoore have you tried on assets?

@t-kelly t-kelly added the !! label Aug 22, 2018
@t-kelly
Copy link
Contributor

t-kelly commented Aug 22, 2018

This may be a regression caused by #647. Will investigate!

@t-kelly t-kelly added the v1.x label Aug 22, 2018
@t-kelly
Copy link
Contributor

t-kelly commented Oct 10, 2018

@zapsilere finally getting to this. On closer inspection, it looks like the path you provide in your SLATE_IGNORE_FILES is found in the src/ directory, not the dist/.

On build, src/assets/static/icons.svg gets copied to dist/assets/icons.svg, so you would need /assets/icons.svg in your SLATE_IGNORE_FILES for it to be ignore.

This definitely was not documented well so totally not your fault for not getting this right. In fact the assets folder is up for a refactor because it's pretty damn confusing right now

Can you confirm /assets/icons.svg works? I will open a PR to clarify docs for now, and there will be PRs in the future to simplify the /assets directory in general.

@lock
Copy link

lock bot commented Nov 14, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants