Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump SigNoz/prometheus #2094

Merged
merged 23 commits into from
Mar 7, 2023
Merged

chore: bump SigNoz/prometheus #2094

merged 23 commits into from
Mar 7, 2023

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Jan 23, 2023 •
edited
Loading

This updates the SigNoz/prometheus version, updated with the recent 0.41.0 changes https://github.com/prometheus/prometheus/releases/tag/v0.41.0, which is used in receiver https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/ed287d6fa99d41f8a414739b783a566d3d325638/receiver/prometheusreceiver/go.mod#L13-L14.

I had to update the k8s.io/apimachinery as well, which was surprising to me because labels from this package is used in alerts struct.

This was the commit that made this change 642ece2#diff-8fccebde3a2fa82468a8383e611ed54353423014598543cf1af4288ffbc09b06. I don't think we are using them anymore and it's not causing the issue. We should probably clear up what's not used anymore.

// @mindhash

@request-info
Copy link

request-info bot commented Jan 23, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions github-actions bot added the chore label Jan 23, 2023
@srikanthccv srikanthccv mentioned this pull request Jan 27, 2023
Closed
@srikanthccv
Copy link
Member Author

@ankitnayan @mindhash I described the changes in our SigNoz/prometheus fork here SigNoz/prometheus#13. I tested these changes and am confident about the /storage part. Can you confirm the /rules changes look good?

@srikanthccv srikanthccv marked this pull request as ready for review February 1, 2023 07:14
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv mentioned this pull request Feb 10, 2023
Merged
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv
Copy link
Member Author

@nityanandagohain @mindhash ping

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv
Copy link
Member Author

Can I get a review/approval on this? I keep fighting the go.mod stash/stash pop, depending on what I am working on.

@srikanthccv
Copy link
Member Author

@ankitnayan can you review this?

ankitnayan
ankitnayan reviewed Feb 21, 2023
View reviewed changes
pkg/query-service/utils/labels/labels.go Show resolved Hide resolved
pkg/query-service/pqlEngine/engine.go Show resolved Hide resolved
pkg/query-service/pqlEngine/engine.go Show resolved Hide resolved
pkg/query-service/pqlEngine/engine.go Show resolved Hide resolved
pkg/query-service/pqlEngine/engine.go Show resolved Hide resolved
pkg/query-service/pqlEngine/engine.go Show resolved Hide resolved
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@srikanthccv srikanthccv merged commit 3f5171d into develop Mar 7, 2023
@srikanthccv srikanthccv deleted the signoz-prom branch March 7, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan approved these changes

@mindhash mindhash mindhash approved these changes

@nityanandagohain nityanandagohain Awaiting requested review from nityanandagohain

Assignees
No one assigned
Labels
chore codeball:needs-careful-review Codeball request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikanthccv @mindhash @ankitnayan