-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add logspout as default docker logs collector #3225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you make same changes to other relevant docker-compose.yaml
files as well?
Also, we need to update Collect Docker Logs documentation. https://signoz.io/docs/userguide/collect_docker_logs/
Sure |
Have added support for swarm and updated the other docker files. Here is the PR for docs https://github.com/SigNoz/signoz.io/pull/1011/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. Please commit the settings.json otherwise someone else with different user settings will introduce different style changes.
deploy/docker-swarm/clickhouse-setup/otel-collector-config.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left couple of comments.
Since query-service
container name for Docker standalone is changed, we will also have to update relevant references.
For example, container name in here: https://signoz.io/docs/operate/sqlite/reset-admin-password#exec-into-query-service-container
Please don't merge it for 1-2 days. I want to check few things. |
11f776a
Good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version changes requested
@prashant-shahi have made the changes with respect to latest version |
Fixes #2855
P.S Default formatting changes are added by VSCode