Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logspout as default docker logs collector #3225

Merged
merged 14 commits into from
Aug 7, 2023
Merged

Conversation

nityanandagohain
Copy link
Member

Fixes #2855

P.S Default formatting changes are added by VSCode

@github-actions github-actions bot added the enhancement New feature or request label Jul 28, 2023
Copy link
Member

@prashant-shahi prashant-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make same changes to other relevant docker-compose.yaml files as well?

Also, we need to update Collect Docker Logs documentation. https://signoz.io/docs/userguide/collect_docker_logs/

@nityanandagohain
Copy link
Member Author

Sure

@nityanandagohain
Copy link
Member Author

Have added support for swarm and updated the other docker files.

Here is the PR for docs https://github.com/SigNoz/signoz.io/pull/1011/files

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Please commit the settings.json otherwise someone else with different user settings will introduce different style changes.

Copy link
Member

@prashant-shahi prashant-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple of comments.

Since query-service container name for Docker standalone is changed, we will also have to update relevant references.

For example, container name in here: https://signoz.io/docs/operate/sqlite/reset-admin-password#exec-into-query-service-container

srikanthccv
srikanthccv previously approved these changes Aug 1, 2023
prashant-shahi
prashant-shahi previously approved these changes Aug 1, 2023
@nityanandagohain
Copy link
Member Author

nityanandagohain commented Aug 2, 2023

Please don't merge it for 1-2 days. I want to check few things.

@nityanandagohain
Copy link
Member Author

Good to go!

Copy link
Member

@prashant-shahi prashant-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version changes requested

deploy/docker-swarm/clickhouse-setup/docker-compose.yaml Outdated Show resolved Hide resolved
deploy/docker/clickhouse-setup/docker-compose.yaml Outdated Show resolved Hide resolved
@nityanandagohain
Copy link
Member Author

@prashant-shahi have made the changes with respect to latest version

@srikanthccv srikanthccv merged commit ae3d4fe into develop Aug 7, 2023
7 of 8 checks passed
@srikanthccv srikanthccv deleted the issue_2855 branch August 7, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LOGS] Add logsprout as the default log collector for docker container logs
3 participants